Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 335b61a

Browse filesBrowse files
addaleaxaddaleax
committed
test: skip node-api/test_worker_terminate_finalization
The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: #34731 PR-URL: #34732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
1 parent b28a6a5 commit 335b61a
Copy full SHA for 335b61a

File tree

Expand file treeCollapse file tree

1 file changed

+5
-0
lines changed
Open diff view settings
Filter options
  • test/node-api/test_worker_terminate_finalization
Expand file treeCollapse file tree

1 file changed

+5
-0
lines changed
Open diff view settings
Collapse file

‎test/node-api/test_worker_terminate_finalization/test.js‎

Copy file name to clipboardExpand all lines: test/node-api/test_worker_terminate_finalization/test.js
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
'use strict';
22
const common = require('../../common');
3+
4+
// TODO(addaleax): Run this test once it stops failing under ASAN/valgrind.
5+
// Refs: https://github.com/nodejs/node/issues/34731
6+
common.skip('Reference management in N-API leaks memory');
7+
38
const { Worker, isMainThread } = require('worker_threads');
49

510
if (isMainThread) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.