Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 32adb70

Browse filesBrowse files
collin5gibfahn
authored andcommitted
test: update http test to use common.mustCall
PR-URL: #17528 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
1 parent 9c93b97 commit 32adb70
Copy full SHA for 32adb70

File tree

Expand file treeCollapse file tree

1 file changed

+5
-17
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-17
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-http-timeout-overflow.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-timeout-overflow.js
+5-17Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,13 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23-
require('../common');
24-
const assert = require('assert');
25-
23+
const common = require('../common');
2624
const http = require('http');
2725

28-
let serverRequests = 0;
29-
let clientRequests = 0;
30-
31-
const server = http.createServer(function(req, res) {
32-
serverRequests++;
26+
const server = http.createServer(common.mustCall(function(req, res) {
3327
res.writeHead(200, { 'Content-Type': 'text/plain' });
3428
res.end('OK');
35-
});
29+
}));
3630

3731
server.listen(0, function() {
3832
function callback() {}
@@ -44,10 +38,9 @@ server.listen(0, function() {
4438
}, function(res) {
4539
req.clearTimeout(callback);
4640

47-
res.on('end', function() {
48-
clientRequests++;
41+
res.on('end', common.mustCall(function() {
4942
server.close();
50-
});
43+
}));
5144

5245
res.resume();
5346
});
@@ -56,8 +49,3 @@ server.listen(0, function() {
5649
req.setTimeout(0xffffffff, callback);
5750
req.end();
5851
});
59-
60-
process.once('exit', function() {
61-
assert.strictEqual(clientRequests, 1);
62-
assert.strictEqual(serverRequests, 1);
63-
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.