Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 326d19a

Browse filesBrowse files
tniessenRafaelGSS
authored andcommitted
src: resolve TODO related to inspector CVEs
This was not done before the security release because the latest CVE was not known at the time. PR-URL: #45341 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 0deed8d commit 326d19a
Copy full SHA for 326d19a

File tree

Expand file treeCollapse file tree

1 file changed

+3
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-4
lines changed
Open diff view settings
Collapse file

‎src/inspector_socket.cc‎

Copy file name to clipboardExpand all lines: src/inspector_socket.cc
+3-4Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,10 @@ static std::string TrimPort(const std::string& host) {
162162
}
163163

164164
static bool IsIPAddress(const std::string& host) {
165-
// TODO(tniessen): add CVEs to the following bullet points
166165
// To avoid DNS rebinding attacks, we are aware of the following requirements:
167-
// * the host name must be an IP address,
168-
// * the IP address must be routable, and
169-
// * the IP address must be formatted unambiguously.
166+
// * the host name must be an IP address (CVE-2018-7160, CVE-2022-32212),
167+
// * the IP address must be routable (hackerone.com/reports/1632921), and
168+
// * the IP address must be formatted unambiguously (CVE-2022-43548).
170169

171170
// The logic below assumes that the string is null-terminated, so ensure that
172171
// we did not somehow end up with null characters within the string.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.