Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 318e2c7

Browse filesBrowse files
santigimenoaduh95
santigimeno
authored and
aduh95
committed
deps: libuv: cherry-pick aabb7651de
Original commit message: win: properly initialize OSVERSIONINFOW (#5107) Otherwise calling `RtlGetVersion()` might produce UB. Problem was causing random crashes in the node.js test suite with stack traces like this one: ``` node.exe!__report_gsfailure(unsigned __int64 stack_cookie) Line 220 at D:\a\_work\1\s\src\vctools\crt\vcstartup\src\gs\gs_report.c(220) ... ``` Fixes: libuv/libuv#5106 Refs: libuv/libuv@aabb765 PR-URL: #62561 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent c6ccbd7 commit 318e2c7
Copy full SHA for 318e2c7

1 file changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎deps/uv/src/win/tcp.c‎

Copy file name to clipboardExpand all lines: deps/uv/src/win/tcp.c
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ static int minimal_windows10_version1709(void) {
5656
OSVERSIONINFOW os_info;
5757
if (!pRtlGetVersion)
5858
return 0;
59+
os_info.dwOSVersionInfoSize = sizeof(os_info);
60+
os_info.szCSDVersion[0] = L'\0';
5961
pRtlGetVersion(&os_info);
6062
if (os_info.dwMajorVersion < 10)
6163
return 0;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.