Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 31293a4

Browse filesBrowse files
zcbenztargos
authored andcommitted
inspector: fix GN build
PR-URL: #56798 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent d436888 commit 31293a4
Copy full SHA for 31293a4

File tree

Expand file treeCollapse file tree

2 files changed

+37
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+37
-1
lines changed
Open diff view settings
Collapse file

‎src/inspector/unofficial.gni‎

Copy file name to clipboardExpand all lines: src/inspector/unofficial.gni
+36-1Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ template("inspector_gn_build") {
1313
}
1414

1515
node_gen_dir = get_label_info("../..", "target_gen_dir")
16-
protocol_tool_path = "../../tools/inspector_protocol"
16+
protocol_tool_path = "../../deps/inspector_protocol"
1717

1818
gypi_values = exec_script(
1919
"../../tools/gypi_to_gn.py",
@@ -35,6 +35,8 @@ template("inspector_gn_build") {
3535
]
3636

3737
args = [
38+
"--inspector_protocol_dir",
39+
rebase_path(protocol_tool_path, root_build_dir),
3840
"--jinja_dir",
3941
# jinja is in third_party.
4042
rebase_path("//third_party/", root_build_dir),
@@ -72,4 +74,37 @@ template("inspector_gn_build") {
7274
outputs = [ "$node_gen_dir/src/{{source_name_part}}.json" ]
7375
args = [ "{{source}}" ] + rebase_path(outputs, root_build_dir)
7476
}
77+
78+
config("crdtp_config") {
79+
include_dirs = [ protocol_tool_path ]
80+
}
81+
82+
static_library("crdtp") {
83+
public_configs = [ ":crdtp_config" ]
84+
sources = [
85+
"$protocol_tool_path/crdtp/cbor.cc",
86+
"$protocol_tool_path/crdtp/cbor.h",
87+
"$protocol_tool_path/crdtp/dispatch.cc",
88+
"$protocol_tool_path/crdtp/dispatch.h",
89+
"$protocol_tool_path/crdtp/error_support.cc",
90+
"$protocol_tool_path/crdtp/error_support.h",
91+
"$protocol_tool_path/crdtp/export.h",
92+
"$protocol_tool_path/crdtp/find_by_first.h",
93+
"$protocol_tool_path/crdtp/frontend_channel.h",
94+
"$protocol_tool_path/crdtp/glue.h",
95+
"$protocol_tool_path/crdtp/json.cc",
96+
"$protocol_tool_path/crdtp/json.h",
97+
"$protocol_tool_path/crdtp/parser_handler.h",
98+
"$protocol_tool_path/crdtp/protocol_core.cc",
99+
"$protocol_tool_path/crdtp/protocol_core.h",
100+
"$protocol_tool_path/crdtp/serializable.cc",
101+
"$protocol_tool_path/crdtp/serializable.h",
102+
"$protocol_tool_path/crdtp/span.cc",
103+
"$protocol_tool_path/crdtp/span.h",
104+
"$protocol_tool_path/crdtp/status.cc",
105+
"$protocol_tool_path/crdtp/status.h",
106+
"$protocol_tool_path/crdtp/json_platform.cc",
107+
"$protocol_tool_path/crdtp/json_platform.h",
108+
]
109+
}
75110
}
Collapse file

‎unofficial.gni‎

Copy file name to clipboardExpand all lines: unofficial.gni
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ template("node_gn_build") {
190190
}
191191
if (node_enable_inspector) {
192192
deps += [
193+
"src/inspector:crdtp",
193194
"src/inspector:node_protocol_generated_sources",
194195
"src/inspector:v8_inspector_compress_protocol_json",
195196
]

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.