Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 30df37f

Browse filesBrowse files
MrJithilruyadorno
authored andcommitted
test: remove error allowance in debugger test
Remove allowance for FATAL ERROR. It is no longer needed. PR-URL: #41640 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
1 parent 8ab0540 commit 30df37f
Copy full SHA for 30df37f

File tree

Expand file treeCollapse file tree

1 file changed

+2
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-5
lines changed
Open diff view settings
Collapse file

‎test/sequential/test-debugger-exceptions.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-exceptions.js
+2-5Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ const path = require('path');
2727
})
2828
// Making sure it will die by default:
2929
.then(() => cli.command('c'))
30-
// TODO: Remove FATAL ERROR once node doesn't show a FATAL ERROR anymore.
31-
.then(() => cli.waitFor(/disconnect|FATAL ERROR/))
30+
.then(() => cli.waitFor(/disconnect/))
3231

3332
// Next run: With `breakOnException` it pauses in both places.
3433
.then(() => cli.stepCommand('r'))
@@ -66,9 +65,7 @@ const path = require('path');
6665
assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
6766
})
6867
.then(() => cli.command('c'))
69-
// TODO: Remove FATAL ERROR once node doesn't show a FATAL ERROR anymore
70-
.then(() => cli.waitFor(/disconnect|FATAL ERROR/))
71-
68+
.then(() => cli.waitFor(/disconnect/))
7269
.then(() => cli.quit())
7370
.then(null, onFatal);
7471
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.