Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3061cb5

Browse filesBrowse files
Eugene OstroukhovBridgeAR
authored andcommitted
inspector, test: verify reported console message
Many Inspector protocol clients rely on the top frame reported for the console messages. This test makes sure correct location is reported. PR-URL: #25455 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 02f1e64 commit 3061cb5
Copy full SHA for 3061cb5

File tree

Expand file treeCollapse file tree

1 file changed

+31
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+31
-0
lines changed
Open diff view settings
Collapse file
+31Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
'use strict';
2+
3+
// Verify that the line containing console.log is reported as a top stack frame
4+
// of the consoleAPICalled notification.
5+
// Changing this will break many Inspector protocol clients, including
6+
// debuggers that use that value for navigating from console messages to code.
7+
8+
const common = require('../common');
9+
common.skipIfInspectorDisabled();
10+
11+
const assert = require('assert');
12+
const { Session } = require('inspector');
13+
const { basename } = require('path');
14+
15+
function logMessage() {
16+
console.log('Log a message');
17+
}
18+
19+
const session = new Session();
20+
let topFrame;
21+
session.once('Runtime.consoleAPICalled', (notification) => {
22+
topFrame = (notification.params.stackTrace.callFrames[0]);
23+
});
24+
session.connect();
25+
session.post('Runtime.enable');
26+
27+
logMessage(); // Triggers Inspector notification
28+
29+
session.disconnect();
30+
assert.strictEqual(basename(topFrame.url), basename(__filename));
31+
assert.strictEqual(topFrame.lineNumber, 15);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.