Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2fe351f

Browse filesBrowse files
addaleaxMylesBorins
authored andcommitted
src: delete CallbackInfo when cleared from cleanup hook
Fixes: #32400 PR-URL: #32405 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 76a7386 commit 2fe351f
Copy full SHA for 2fe351f

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎src/node_buffer.cc‎

Copy file name to clipboardExpand all lines: src/node_buffer.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,14 @@ void CallbackInfo::WeakCallback(
163163
const WeakCallbackInfo<CallbackInfo>& data) {
164164
CallbackInfo* self = data.GetParameter();
165165
self->WeakCallback(data.GetIsolate());
166-
delete self;
167166
}
168167

169168

170169
void CallbackInfo::WeakCallback(Isolate* isolate) {
171170
callback_(data_, hint_);
172171
int64_t change_in_bytes = -static_cast<int64_t>(sizeof(*this));
173172
isolate->AdjustAmountOfExternalAllocatedMemory(change_in_bytes);
173+
delete this;
174174
}
175175

176176

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.