Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2fd0f79

Browse filesBrowse files
kvakiltargos
kvakil
authored and
targos
committed
src: fix duplication of externalized builtin code
The `else` here was missing, causing us to append the file to its existing `source` already in the map. Refs: #45942 PR-URL: #47079 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 5a43586 commit 2fd0f79
Copy full SHA for 2fd0f79

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎src/node_builtins.cc‎

Copy file name to clipboardExpand all lines: src/node_builtins.cc
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,7 @@ void BuiltinLoader::AddExternalizedBuiltin(const char* id,
227227
auto it = externalized_builtin_sources.find(id);
228228
if (it != externalized_builtin_sources.end()) {
229229
source = it->second;
230-
}
231-
{
230+
} else {
232231
int r = ReadFileSync(&source, filename);
233232
if (r != 0) {
234233
fprintf(stderr,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.