Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2fb8257

Browse filesBrowse files
Trottaddaleax
Trott
authored and
addaleax
committed
test: fix flaky test-inspector
Using `socket.destroy()` instead of `socket.end()` fixes more-than-intermittent ECONNRESET issues on Windows. PR-URL: #9727 Fixes: #8804 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
1 parent fc13cc6 commit 2fb8257
Copy full SHA for 2fb8257

File tree

Expand file treeCollapse file tree

2 files changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎test/inspector/inspector-helper.js‎

Copy file name to clipboardExpand all lines: test/inspector/inspector-helper.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ TestSession.prototype.disconnect = function(childDone) {
286286
this.expectClose_ = true;
287287
this.harness_.childInstanceDone =
288288
this.harness_.childInstanceDone || childDone;
289-
this.socket_.end();
289+
this.socket_.destroy();
290290
console.log('[test]', 'Connection terminated');
291291
callback();
292292
});
Collapse file

‎test/inspector/inspector.status‎

Copy file name to clipboardExpand all lines: test/inspector/inspector.status
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,3 @@ prefix inspector
77
[true] # This section applies to all platforms
88

99
[$system==win32]
10-
test-inspector : PASS,FLAKY

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.