Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2f8bc9a

Browse filesBrowse files
cjihrigMylesBorins
cjihrig
authored and
MylesBorins
committed
test: s/ASSERT/assert/
This commit addresses an inconsistency with eight tests. These tests use the assert module, but named the variable ASSERT. This goes against the project's typical coding style, and negatively impacts global find and replace updates. PR-URL: #10544 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 380a5d5 commit 2f8bc9a
Copy full SHA for 2f8bc9a

File tree

Expand file treeCollapse file tree

8 files changed

+437
-437
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

8 files changed

+437
-437
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-readdouble.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-readdouble.js
+31-31Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Tests to verify we're reading in doubles correctly
44
*/
55
require('../common');
6-
var ASSERT = require('assert');
6+
const assert = require('assert');
77

88
/*
99
* Test (64 bit) double
@@ -19,8 +19,8 @@ function test(clazz) {
1919
buffer[5] = 0x55;
2020
buffer[6] = 0xd5;
2121
buffer[7] = 0x3f;
22-
ASSERT.equal(1.1945305291680097e+103, buffer.readDoubleBE(0));
23-
ASSERT.equal(0.3333333333333333, buffer.readDoubleLE(0));
22+
assert.equal(1.1945305291680097e+103, buffer.readDoubleBE(0));
23+
assert.equal(0.3333333333333333, buffer.readDoubleLE(0));
2424

2525
buffer[0] = 1;
2626
buffer[1] = 0;
@@ -30,18 +30,18 @@ function test(clazz) {
3030
buffer[5] = 0;
3131
buffer[6] = 0xf0;
3232
buffer[7] = 0x3f;
33-
ASSERT.equal(7.291122019655968e-304, buffer.readDoubleBE(0));
34-
ASSERT.equal(1.0000000000000002, buffer.readDoubleLE(0));
33+
assert.equal(7.291122019655968e-304, buffer.readDoubleBE(0));
34+
assert.equal(1.0000000000000002, buffer.readDoubleLE(0));
3535

3636
buffer[0] = 2;
37-
ASSERT.equal(4.778309726801735e-299, buffer.readDoubleBE(0));
38-
ASSERT.equal(1.0000000000000004, buffer.readDoubleLE(0));
37+
assert.equal(4.778309726801735e-299, buffer.readDoubleBE(0));
38+
assert.equal(1.0000000000000004, buffer.readDoubleLE(0));
3939

4040
buffer[0] = 1;
4141
buffer[6] = 0;
4242
buffer[7] = 0;
43-
ASSERT.equal(7.291122019556398e-304, buffer.readDoubleBE(0));
44-
ASSERT.equal(5e-324, buffer.readDoubleLE(0));
43+
assert.equal(7.291122019556398e-304, buffer.readDoubleBE(0));
44+
assert.equal(5e-324, buffer.readDoubleLE(0));
4545

4646
buffer[0] = 0xff;
4747
buffer[1] = 0xff;
@@ -51,13 +51,13 @@ function test(clazz) {
5151
buffer[5] = 0xff;
5252
buffer[6] = 0x0f;
5353
buffer[7] = 0x00;
54-
ASSERT.ok(isNaN(buffer.readDoubleBE(0)));
55-
ASSERT.equal(2.225073858507201e-308, buffer.readDoubleLE(0));
54+
assert.ok(isNaN(buffer.readDoubleBE(0)));
55+
assert.equal(2.225073858507201e-308, buffer.readDoubleLE(0));
5656

5757
buffer[6] = 0xef;
5858
buffer[7] = 0x7f;
59-
ASSERT.ok(isNaN(buffer.readDoubleBE(0)));
60-
ASSERT.equal(1.7976931348623157e+308, buffer.readDoubleLE(0));
59+
assert.ok(isNaN(buffer.readDoubleBE(0)));
60+
assert.equal(1.7976931348623157e+308, buffer.readDoubleLE(0));
6161

6262
buffer[0] = 0;
6363
buffer[1] = 0;
@@ -67,42 +67,42 @@ function test(clazz) {
6767
buffer[5] = 0;
6868
buffer[6] = 0xf0;
6969
buffer[7] = 0x3f;
70-
ASSERT.equal(3.03865e-319, buffer.readDoubleBE(0));
71-
ASSERT.equal(1, buffer.readDoubleLE(0));
70+
assert.equal(3.03865e-319, buffer.readDoubleBE(0));
71+
assert.equal(1, buffer.readDoubleLE(0));
7272

7373
buffer[6] = 0;
7474
buffer[7] = 0x40;
75-
ASSERT.equal(3.16e-322, buffer.readDoubleBE(0));
76-
ASSERT.equal(2, buffer.readDoubleLE(0));
75+
assert.equal(3.16e-322, buffer.readDoubleBE(0));
76+
assert.equal(2, buffer.readDoubleLE(0));
7777

7878
buffer[7] = 0xc0;
79-
ASSERT.equal(9.5e-322, buffer.readDoubleBE(0));
80-
ASSERT.equal(-2, buffer.readDoubleLE(0));
79+
assert.equal(9.5e-322, buffer.readDoubleBE(0));
80+
assert.equal(-2, buffer.readDoubleLE(0));
8181

8282
buffer[6] = 0x10;
8383
buffer[7] = 0;
84-
ASSERT.equal(2.0237e-320, buffer.readDoubleBE(0));
85-
ASSERT.equal(2.2250738585072014e-308, buffer.readDoubleLE(0));
84+
assert.equal(2.0237e-320, buffer.readDoubleBE(0));
85+
assert.equal(2.2250738585072014e-308, buffer.readDoubleLE(0));
8686

8787
buffer[6] = 0;
88-
ASSERT.equal(0, buffer.readDoubleBE(0));
89-
ASSERT.equal(0, buffer.readDoubleLE(0));
90-
ASSERT.equal(false, 1 / buffer.readDoubleLE(0) < 0);
88+
assert.equal(0, buffer.readDoubleBE(0));
89+
assert.equal(0, buffer.readDoubleLE(0));
90+
assert.equal(false, 1 / buffer.readDoubleLE(0) < 0);
9191

9292
buffer[7] = 0x80;
93-
ASSERT.equal(6.3e-322, buffer.readDoubleBE(0));
94-
ASSERT.equal(0, buffer.readDoubleLE(0));
95-
ASSERT.equal(true, 1 / buffer.readDoubleLE(0) < 0);
93+
assert.equal(6.3e-322, buffer.readDoubleBE(0));
94+
assert.equal(0, buffer.readDoubleLE(0));
95+
assert.equal(true, 1 / buffer.readDoubleLE(0) < 0);
9696

9797
buffer[6] = 0xf0;
9898
buffer[7] = 0x7f;
99-
ASSERT.equal(3.0418e-319, buffer.readDoubleBE(0));
100-
ASSERT.equal(Infinity, buffer.readDoubleLE(0));
99+
assert.equal(3.0418e-319, buffer.readDoubleBE(0));
100+
assert.equal(Infinity, buffer.readDoubleLE(0));
101101

102102
buffer[6] = 0xf0;
103103
buffer[7] = 0xff;
104-
ASSERT.equal(3.04814e-319, buffer.readDoubleBE(0));
105-
ASSERT.equal(-Infinity, buffer.readDoubleLE(0));
104+
assert.equal(3.04814e-319, buffer.readDoubleBE(0));
105+
assert.equal(-Infinity, buffer.readDoubleLE(0));
106106
}
107107

108108

Collapse file

‎test/parallel/test-readfloat.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-readfloat.js
+19-19Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Tests to verify we're reading in floats correctly
44
*/
55
require('../common');
6-
var ASSERT = require('assert');
6+
const assert = require('assert');
77

88
/*
99
* Test (32 bit) float
@@ -15,56 +15,56 @@ function test(clazz) {
1515
buffer[1] = 0;
1616
buffer[2] = 0x80;
1717
buffer[3] = 0x3f;
18-
ASSERT.equal(4.600602988224807e-41, buffer.readFloatBE(0));
19-
ASSERT.equal(1, buffer.readFloatLE(0));
18+
assert.equal(4.600602988224807e-41, buffer.readFloatBE(0));
19+
assert.equal(1, buffer.readFloatLE(0));
2020

2121
buffer[0] = 0;
2222
buffer[1] = 0;
2323
buffer[2] = 0;
2424
buffer[3] = 0xc0;
25-
ASSERT.equal(2.6904930515036488e-43, buffer.readFloatBE(0));
26-
ASSERT.equal(-2, buffer.readFloatLE(0));
25+
assert.equal(2.6904930515036488e-43, buffer.readFloatBE(0));
26+
assert.equal(-2, buffer.readFloatLE(0));
2727

2828
buffer[0] = 0xff;
2929
buffer[1] = 0xff;
3030
buffer[2] = 0x7f;
3131
buffer[3] = 0x7f;
32-
ASSERT.ok(isNaN(buffer.readFloatBE(0)));
33-
ASSERT.equal(3.4028234663852886e+38, buffer.readFloatLE(0));
32+
assert.ok(isNaN(buffer.readFloatBE(0)));
33+
assert.equal(3.4028234663852886e+38, buffer.readFloatLE(0));
3434

3535
buffer[0] = 0xab;
3636
buffer[1] = 0xaa;
3737
buffer[2] = 0xaa;
3838
buffer[3] = 0x3e;
39-
ASSERT.equal(-1.2126478207002966e-12, buffer.readFloatBE(0));
40-
ASSERT.equal(0.3333333432674408, buffer.readFloatLE(0));
39+
assert.equal(-1.2126478207002966e-12, buffer.readFloatBE(0));
40+
assert.equal(0.3333333432674408, buffer.readFloatLE(0));
4141

4242
buffer[0] = 0;
4343
buffer[1] = 0;
4444
buffer[2] = 0;
4545
buffer[3] = 0;
46-
ASSERT.equal(0, buffer.readFloatBE(0));
47-
ASSERT.equal(0, buffer.readFloatLE(0));
48-
ASSERT.equal(false, 1 / buffer.readFloatLE(0) < 0);
46+
assert.equal(0, buffer.readFloatBE(0));
47+
assert.equal(0, buffer.readFloatLE(0));
48+
assert.equal(false, 1 / buffer.readFloatLE(0) < 0);
4949

5050
buffer[3] = 0x80;
51-
ASSERT.equal(1.793662034335766e-43, buffer.readFloatBE(0));
52-
ASSERT.equal(0, buffer.readFloatLE(0));
53-
ASSERT.equal(true, 1 / buffer.readFloatLE(0) < 0);
51+
assert.equal(1.793662034335766e-43, buffer.readFloatBE(0));
52+
assert.equal(0, buffer.readFloatLE(0));
53+
assert.equal(true, 1 / buffer.readFloatLE(0) < 0);
5454

5555
buffer[0] = 0;
5656
buffer[1] = 0;
5757
buffer[2] = 0x80;
5858
buffer[3] = 0x7f;
59-
ASSERT.equal(4.609571298396486e-41, buffer.readFloatBE(0));
60-
ASSERT.equal(Infinity, buffer.readFloatLE(0));
59+
assert.equal(4.609571298396486e-41, buffer.readFloatBE(0));
60+
assert.equal(Infinity, buffer.readFloatLE(0));
6161

6262
buffer[0] = 0;
6363
buffer[1] = 0;
6464
buffer[2] = 0x80;
6565
buffer[3] = 0xff;
66-
ASSERT.equal(4.627507918739843e-41, buffer.readFloatBE(0));
67-
ASSERT.equal(-Infinity, buffer.readFloatLE(0));
66+
assert.equal(4.627507918739843e-41, buffer.readFloatBE(0));
67+
assert.equal(-Infinity, buffer.readFloatLE(0));
6868
}
6969

7070

Collapse file

‎test/parallel/test-readint.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-readint.js
+31-31Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Tests to verify we're reading in signed integers correctly
44
*/
55
require('../common');
6-
var ASSERT = require('assert');
6+
const assert = require('assert');
77

88
/*
99
* Test 8 bit signed integers
@@ -12,19 +12,19 @@ function test8(clazz) {
1212
var data = new clazz(4);
1313

1414
data[0] = 0x23;
15-
ASSERT.equal(0x23, data.readInt8(0));
15+
assert.equal(0x23, data.readInt8(0));
1616

1717
data[0] = 0xff;
18-
ASSERT.equal(-1, data.readInt8(0));
18+
assert.equal(-1, data.readInt8(0));
1919

2020
data[0] = 0x87;
2121
data[1] = 0xab;
2222
data[2] = 0x7c;
2323
data[3] = 0xef;
24-
ASSERT.equal(-121, data.readInt8(0));
25-
ASSERT.equal(-85, data.readInt8(1));
26-
ASSERT.equal(124, data.readInt8(2));
27-
ASSERT.equal(-17, data.readInt8(3));
24+
assert.equal(-121, data.readInt8(0));
25+
assert.equal(-85, data.readInt8(1));
26+
assert.equal(124, data.readInt8(2));
27+
assert.equal(-17, data.readInt8(3));
2828
}
2929

3030

@@ -33,13 +33,13 @@ function test16(clazz) {
3333

3434
buffer[0] = 0x16;
3535
buffer[1] = 0x79;
36-
ASSERT.equal(0x1679, buffer.readInt16BE(0));
37-
ASSERT.equal(0x7916, buffer.readInt16LE(0));
36+
assert.equal(0x1679, buffer.readInt16BE(0));
37+
assert.equal(0x7916, buffer.readInt16LE(0));
3838

3939
buffer[0] = 0xff;
4040
buffer[1] = 0x80;
41-
ASSERT.equal(-128, buffer.readInt16BE(0));
42-
ASSERT.equal(-32513, buffer.readInt16LE(0));
41+
assert.equal(-128, buffer.readInt16BE(0));
42+
assert.equal(-32513, buffer.readInt16LE(0));
4343

4444
/* test offset with weenix */
4545
buffer[0] = 0x77;
@@ -48,16 +48,16 @@ function test16(clazz) {
4848
buffer[3] = 0x6e;
4949
buffer[4] = 0x69;
5050
buffer[5] = 0x78;
51-
ASSERT.equal(0x7765, buffer.readInt16BE(0));
52-
ASSERT.equal(0x6565, buffer.readInt16BE(1));
53-
ASSERT.equal(0x656e, buffer.readInt16BE(2));
54-
ASSERT.equal(0x6e69, buffer.readInt16BE(3));
55-
ASSERT.equal(0x6978, buffer.readInt16BE(4));
56-
ASSERT.equal(0x6577, buffer.readInt16LE(0));
57-
ASSERT.equal(0x6565, buffer.readInt16LE(1));
58-
ASSERT.equal(0x6e65, buffer.readInt16LE(2));
59-
ASSERT.equal(0x696e, buffer.readInt16LE(3));
60-
ASSERT.equal(0x7869, buffer.readInt16LE(4));
51+
assert.equal(0x7765, buffer.readInt16BE(0));
52+
assert.equal(0x6565, buffer.readInt16BE(1));
53+
assert.equal(0x656e, buffer.readInt16BE(2));
54+
assert.equal(0x6e69, buffer.readInt16BE(3));
55+
assert.equal(0x6978, buffer.readInt16BE(4));
56+
assert.equal(0x6577, buffer.readInt16LE(0));
57+
assert.equal(0x6565, buffer.readInt16LE(1));
58+
assert.equal(0x6e65, buffer.readInt16LE(2));
59+
assert.equal(0x696e, buffer.readInt16LE(3));
60+
assert.equal(0x7869, buffer.readInt16LE(4));
6161
}
6262

6363

@@ -68,28 +68,28 @@ function test32(clazz) {
6868
buffer[1] = 0x53;
6969
buffer[2] = 0x16;
7070
buffer[3] = 0x79;
71-
ASSERT.equal(0x43531679, buffer.readInt32BE(0));
72-
ASSERT.equal(0x79165343, buffer.readInt32LE(0));
71+
assert.equal(0x43531679, buffer.readInt32BE(0));
72+
assert.equal(0x79165343, buffer.readInt32LE(0));
7373

7474
buffer[0] = 0xff;
7575
buffer[1] = 0xfe;
7676
buffer[2] = 0xef;
7777
buffer[3] = 0xfa;
78-
ASSERT.equal(-69638, buffer.readInt32BE(0));
79-
ASSERT.equal(-84934913, buffer.readInt32LE(0));
78+
assert.equal(-69638, buffer.readInt32BE(0));
79+
assert.equal(-84934913, buffer.readInt32LE(0));
8080

8181
buffer[0] = 0x42;
8282
buffer[1] = 0xc3;
8383
buffer[2] = 0x95;
8484
buffer[3] = 0xa9;
8585
buffer[4] = 0x36;
8686
buffer[5] = 0x17;
87-
ASSERT.equal(0x42c395a9, buffer.readInt32BE(0));
88-
ASSERT.equal(-1013601994, buffer.readInt32BE(1));
89-
ASSERT.equal(-1784072681, buffer.readInt32BE(2));
90-
ASSERT.equal(-1449802942, buffer.readInt32LE(0));
91-
ASSERT.equal(917083587, buffer.readInt32LE(1));
92-
ASSERT.equal(389458325, buffer.readInt32LE(2));
87+
assert.equal(0x42c395a9, buffer.readInt32BE(0));
88+
assert.equal(-1013601994, buffer.readInt32BE(1));
89+
assert.equal(-1784072681, buffer.readInt32BE(2));
90+
assert.equal(-1449802942, buffer.readInt32LE(0));
91+
assert.equal(917083587, buffer.readInt32LE(1));
92+
assert.equal(389458325, buffer.readInt32LE(2));
9393
}
9494

9595

Collapse file

‎test/parallel/test-readuint.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-readuint.js
+20-20Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
require('../common');
7-
var ASSERT = require('assert');
7+
const assert = require('assert');
88

99
/*
1010
* We need to check the following things:
@@ -20,13 +20,13 @@ function test8(clazz) {
2020
data[1] = 23;
2121
data[2] = 23;
2222
data[3] = 23;
23-
ASSERT.equal(23, data.readUInt8(0));
24-
ASSERT.equal(23, data.readUInt8(1));
25-
ASSERT.equal(23, data.readUInt8(2));
26-
ASSERT.equal(23, data.readUInt8(3));
23+
assert.equal(23, data.readUInt8(0));
24+
assert.equal(23, data.readUInt8(1));
25+
assert.equal(23, data.readUInt8(2));
26+
assert.equal(23, data.readUInt8(3));
2727

2828
data[0] = 255; /* If it became a signed int, would be -1 */
29-
ASSERT.equal(255, data.readUInt8(0));
29+
assert.equal(255, data.readUInt8(0));
3030
}
3131

3232

@@ -45,17 +45,17 @@ function test16(clazz) {
4545
data[1] = 0x23;
4646
data[2] = 0x42;
4747
data[3] = 0x3f;
48-
ASSERT.equal(0x23, data.readUInt16BE(0));
49-
ASSERT.equal(0x2342, data.readUInt16BE(1));
50-
ASSERT.equal(0x423f, data.readUInt16BE(2));
51-
ASSERT.equal(0x2300, data.readUInt16LE(0));
52-
ASSERT.equal(0x4223, data.readUInt16LE(1));
53-
ASSERT.equal(0x3f42, data.readUInt16LE(2));
48+
assert.equal(0x23, data.readUInt16BE(0));
49+
assert.equal(0x2342, data.readUInt16BE(1));
50+
assert.equal(0x423f, data.readUInt16BE(2));
51+
assert.equal(0x2300, data.readUInt16LE(0));
52+
assert.equal(0x4223, data.readUInt16LE(1));
53+
assert.equal(0x3f42, data.readUInt16LE(2));
5454

5555
data[0] = 0xfe;
5656
data[1] = 0xfe;
57-
ASSERT.equal(0xfefe, data.readUInt16BE(0));
58-
ASSERT.equal(0xfefe, data.readUInt16LE(0));
57+
assert.equal(0xfefe, data.readUInt16BE(0));
58+
assert.equal(0xfefe, data.readUInt16LE(0));
5959
}
6060

6161

@@ -75,12 +75,12 @@ function test32(clazz) {
7575
data[3] = 0x56;
7676
data[4] = 0x23;
7777
data[5] = 0xff;
78-
ASSERT.equal(0x32654256, data.readUInt32BE(0));
79-
ASSERT.equal(0x65425623, data.readUInt32BE(1));
80-
ASSERT.equal(0x425623ff, data.readUInt32BE(2));
81-
ASSERT.equal(0x56426532, data.readUInt32LE(0));
82-
ASSERT.equal(0x23564265, data.readUInt32LE(1));
83-
ASSERT.equal(0xff235642, data.readUInt32LE(2));
78+
assert.equal(0x32654256, data.readUInt32BE(0));
79+
assert.equal(0x65425623, data.readUInt32BE(1));
80+
assert.equal(0x425623ff, data.readUInt32BE(2));
81+
assert.equal(0x56426532, data.readUInt32LE(0));
82+
assert.equal(0x23564265, data.readUInt32LE(1));
83+
assert.equal(0xff235642, data.readUInt32LE(2));
8484
}
8585

8686

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.