Commit 2ef1702
authored
tls: use
If user sets invalid type for options.minDHSize in
tls.connect(), it's not internal issue of Node.js. So
validateNumber() is more proper than assert(). Plus,
set min of validateNumber() as 1 to check minDHSize
is positive.
Refs: #49896
PR-URL: #49973
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>validateNumber for options.minDHSize
1 parent 136a967 commit 2ef1702Copy full SHA for 2ef1702
File tree
Expand file treeCollapse file tree
2 files changed
+17
-14
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+17
-14
lines changedOpen diff view settings
Collapse file
+1-5Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1749 | 1749 | |
1750 | 1750 | |
1751 | 1751 | |
1752 | | - |
1753 | | - |
1754 | | - |
1755 | | - |
1756 | | - |
| 1752 | + |
1757 | 1753 | |
1758 | 1754 | |
1759 | 1755 | |
|
Collapse file
test/parallel/test-tls-client-mindhsize.js
Copy file name to clipboardExpand all lines: test/parallel/test-tls-client-mindhsize.js+16-9Lines changed: 16 additions & 9 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
74 | 74 | |
75 | 75 | |
76 | 76 | |
77 | | - |
78 | | - |
79 | | - |
80 | | - |
81 | | - |
| 77 | + |
| 78 | + |
| 79 | + |
| 80 | + |
| 81 | + |
| 82 | + |
| 83 | + |
| 84 | + |
82 | 85 | |
83 | | - |
84 | | - |
85 | | - |
86 | | - |
| 86 | + |
| 87 | + |
| 88 | + |
| 89 | + |
| 90 | + |
| 91 | + |
| 92 | + |
| 93 | + |
87 | 94 | |
88 | 95 | |
89 | 96 | |
|
0 commit comments