Commit 2eb097f
src: fix MakeCallback error handling
Implementations of error handling between node::MakeCallback() and
AsyncWrap::MakeCallback() do not return at the same point. Make both
executions work the same by moving the early return if there's a caught
exception just after the AsyncWrap post callback. Since the domain's
call stack is cleared on a caught exception there is no reason to call
its exit() callback.
Remove the SetVerbose() statement in the AsyncWrap pre/post callback
calls since it does not affect the callback call.
Ref: #7048
PR-URL: #4507
Reviewed-By: Fedor Indutny <fedor@indutny.com>1 parent da9595f commit 2eb097fCopy full SHA for 2eb097f
File tree
Expand file treeCollapse file tree
2 files changed
+10
-16
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
2 files changed
+10
-16
lines changedOpen diff view settings
Collapse file
+5-8Lines changed: 5 additions & 8 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
207 | 207 | |
208 | 208 | |
209 | 209 | |
210 | | - |
211 | 210 | |
212 | 211 | |
213 | 212 | |
214 | | - |
215 | 213 | |
216 | 214 | |
217 | 215 | |
218 | 216 | |
219 | | - |
220 | | - |
221 | | - |
222 | | - |
223 | 217 | |
224 | | - |
225 | 218 | |
226 | 219 | |
227 | 220 | |
228 | | - |
| 221 | + |
| 222 | + |
| 223 | + |
| 224 | + |
| 225 | + |
229 | 226 | |
230 | 227 | |
231 | 228 | |
|
Collapse file
+5-8Lines changed: 5 additions & 8 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1165 | 1165 | |
1166 | 1166 | |
1167 | 1167 | |
1168 | | - |
1169 | 1168 | |
1170 | 1169 | |
1171 | 1170 | |
1172 | | - |
1173 | 1171 | |
1174 | 1172 | |
1175 | 1173 | |
1176 | 1174 | |
1177 | 1175 | |
1178 | | - |
1179 | 1176 | |
1180 | 1177 | |
1181 | 1178 | |
1182 | | - |
| 1179 | + |
| 1180 | + |
| 1181 | + |
| 1182 | + |
| 1183 | + |
1183 | 1184 | |
1184 | 1185 | |
1185 | 1186 | |
| ||
1191 | 1192 | |
1192 | 1193 | |
1193 | 1194 | |
1194 | | - |
1195 | | - |
1196 | | - |
1197 | | - |
1198 | 1195 | |
1199 | 1196 | |
1200 | 1197 | |
|
0 commit comments