Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2ea4cc0

Browse filesBrowse files
ronagtargos
authored andcommitted
doc: clarify pipeline stream cleanup
PR-URL: #29738 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent ab060bf commit 2ea4cc0
Copy full SHA for 2ea4cc0

File tree

Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Open diff view settings
Collapse file

‎doc/api/stream.md‎

Copy file name to clipboardExpand all lines: doc/api/stream.md
+4Lines changed: 4 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1587,6 +1587,10 @@ async function run() {
15871587
run().catch(console.error);
15881588
```
15891589

1590+
`stream.pipeline()` will call `stream.destroy(err)` on all streams except:
1591+
* `Readable` streams which have emitted `'end'` or `'close'`.
1592+
* `Writable` streams which have emitted `'finish'` or `'close'`.
1593+
15901594
`stream.pipeline()` leaves dangling event listeners on the streams
15911595
after the `callback` has been invoked. In the case of reuse of streams after
15921596
failure, this can cause event listener leaks and swallowed errors.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.