Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2ea0672

Browse filesBrowse files
richardlauaduh95
authored andcommitted
test: skip strace test with shared openssl
`parallel/test-strace-openat-openssl` was added to check explicitly for a list of known files that would be opened for a set workload (`require("crypto")`). This is not reliable when Node.js is linked to an external/shared OpenSSL library (e.g. it might be configured to load configuration files from a different default location and/or load more than one configuration file) so skip this test when Node.js is built in that way. PR-URL: #61987 Fixes: #61966 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent 16b8cc6 commit 2ea0672
Copy full SHA for 2ea0672

1 file changed

+3Lines changed: 3 additions & 0 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎test/parallel/test-strace-openat-openssl.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-strace-openat-openssl.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ if (!common.isLinux)
1111
common.skip('linux only');
1212
if (common.isASan)
1313
common.skip('strace does not work well with address sanitizer builds');
14+
if (process.config.variables.node_shared_openssl) {
15+
common.skip('external shared openssl may open other files');
16+
}
1417
if (spawnSync('strace').error !== undefined) {
1518
common.skip('missing strace');
1619
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.