Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2db83fd

Browse filesBrowse files
ceccodeaddaleax
authored andcommitted
test: remove deepStrictEqual() third argument
The call to assert.deepStrictEqual() has a string literal for its third argument. Unfortunately, a side effect of that is that the values of the first two arguments are not displayed if there is an AssertionError. That information is useful for debugging. PR-URL: #20702 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent ebc1b77 commit 2db83fd
Copy full SHA for 2db83fd

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-net-socket-local-address.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-net-socket-local-address.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ const server = net.createServer((socket) => {
1717
});
1818

1919
server.on('close', common.mustCall(() => {
20-
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts,
21-
'client and server should agree on the ports used');
20+
// client and server should agree on the ports used
21+
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts);
2222
assert.strictEqual(2, conns);
2323
}));
2424

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.