Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2d63b65

Browse filesBrowse files
ka3egibfahn
authored andcommitted
test: refactor addons-napi/test_promise/test.js
* remove custom messages for assert that conceal values * add comment explaining test * add block scoping PR-URL: #16814 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent b1802ed commit 2d63b65
Copy full SHA for 2d63b65

File tree

Expand file treeCollapse file tree

1 file changed

+17
-14
lines changed
Open diff view settings
Filter options
  • test/addons-napi/test_promise
Expand file treeCollapse file tree

1 file changed

+17
-14
lines changed
Open diff view settings
Collapse file

‎test/addons-napi/test_promise/test.js‎

Copy file name to clipboardExpand all lines: test/addons-napi/test_promise/test.js
+17-14Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
11
'use strict';
22

33
const common = require('../../common');
4-
const test_promise = require(`./build/${common.buildType}/test_promise`);
4+
5+
// This tests the promise-related n-api calls
6+
57
const assert = require('assert');
8+
const test_promise = require(`./build/${common.buildType}/test_promise`);
69

710
// A resolution
811
{
912
const expected_result = 42;
1013
const promise = test_promise.createPromise();
1114
promise.then(
1215
common.mustCall(function(result) {
13-
assert.strictEqual(result, expected_result,
14-
`promise resolved as expected, received ${result}`);
16+
assert.strictEqual(result, expected_result);
1517
}),
1618
common.mustNotCall());
1719
test_promise.concludeCurrentPromise(expected_result, true);
@@ -24,23 +26,24 @@ const assert = require('assert');
2426
promise.then(
2527
common.mustNotCall(),
2628
common.mustCall(function(result) {
27-
assert.strictEqual(result, expected_result,
28-
`promise rejected as expected, received ${result}`);
29+
assert.strictEqual(result, expected_result);
2930
}));
3031
test_promise.concludeCurrentPromise(expected_result, false);
3132
}
3233

3334
// Chaining
34-
const promise = test_promise.createPromise();
35-
promise.then(
36-
common.mustCall(function(result) {
37-
assert.strictEqual(result, 'chained answer',
38-
'resolving with a promise chains properly');
39-
}),
40-
common.mustNotCall());
41-
test_promise.concludeCurrentPromise(Promise.resolve('chained answer'), true);
35+
{
36+
const expected_result = 'chained answer';
37+
const promise = test_promise.createPromise();
38+
promise.then(
39+
common.mustCall(function(result) {
40+
assert.strictEqual(result, expected_result);
41+
}),
42+
common.mustNotCall());
43+
test_promise.concludeCurrentPromise(Promise.resolve('chained answer'), true);
44+
}
4245

43-
assert.strictEqual(test_promise.isPromise(promise), true);
46+
assert.strictEqual(test_promise.isPromise(test_promise.createPromise()), true);
4447
assert.strictEqual(test_promise.isPromise(Promise.reject(-1)), true);
4548
assert.strictEqual(test_promise.isPromise(2.4), false);
4649
assert.strictEqual(test_promise.isPromise('I promise!'), false);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.