Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2d59273

Browse filesBrowse files
Trotttargos
Trott
authored and
targos
committed
doc: indicate that abort tests do not generate core files
The key thing about the tests in `test/abort` is that tests in that directory do not generate core files (thanks to testcfg.py). Make a note of that in the test README. PR-URL: #38422 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent f197012 commit 2d59273
Copy full SHA for 2d59273

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎test/README.md‎

Copy file name to clipboardExpand all lines: test/README.md
+1-1Lines changed: 1 addition & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ For the tests to run on Windows, be sure to clone Node.js source code with the
1515

1616
| Directory | Runs on CI | Purpose |
1717
| ---------------- | ---------- | --------------- |
18-
| `abort` | Yes | Tests for when the `--abort-on-uncaught-exception` flag is used. |
18+
| `abort` | Yes | Tests that use `--abort-on-uncaught-exception` and other situations where we want to test something but avoid generating a core file. |
1919
| `addons` | Yes | Tests for [addon](https://nodejs.org/api/addons.html) functionality along with some tests that require an addon. |
2020
| `async-hooks` | Yes | Tests for [async_hooks](https://nodejs.org/api/async_hooks.html) functionality. |
2121
| `benchmark` | Yes | Test minimal functionality of benchmarks. |

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.