Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2d32922

Browse filesBrowse files
TrottMylesBorins
authored andcommitted
test: rename common.ddCommand()
Change common.ddCommand() to common.createZeroFilledFile(). Backport-PR-URL: #23630 PR-URL: #23411 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
1 parent 2f84a18 commit 2d32922
Copy full SHA for 2d32922

File tree

Expand file treeCollapse file tree

5 files changed

+7
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

5 files changed

+7
-7
lines changed
Open diff view settings
Collapse file

‎test/common/README.md‎

Copy file name to clipboardExpand all lines: test/common/README.md
+1-1Lines changed: 1 addition & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ symlinks
5252
([SeCreateSymbolicLinkPrivilege](https://msdn.microsoft.com/en-us/library/windows/desktop/bb530716(v=vs.85).aspx)).
5353
On non-Windows platforms, this always returns `true`.
5454

55-
### ddCommand(filename)
55+
### createZeroFilledFile(filename)
5656

5757
Creates a 10 MB file of all null characters.
5858

Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ function childShouldThrowAndAbort() {
173173
});
174174
}
175175

176-
function ddCommand(filename) {
176+
function createZeroFilledFile(filename) {
177177
const fd = fs.openSync(filename, 'w');
178178
fs.ftruncateSync(fd, 10 * 1024 * 1024);
179179
fs.closeSync(fd);
@@ -696,7 +696,7 @@ module.exports = {
696696
busyLoop,
697697
canCreateSymLink,
698698
childShouldThrowAndAbort,
699-
ddCommand,
699+
createZeroFilledFile,
700700
disableCrashOnUnhandledRejection,
701701
enoughTestCpu,
702702
enoughTestMem,
Collapse file

‎test/common/index.mjs‎

Copy file name to clipboardExpand all lines: test/common/index.mjs
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const {
2222
PIPE,
2323
hasIPv6,
2424
childShouldThrowAndAbort,
25-
ddCommand,
25+
createZeroFilledFile,
2626
platformTimeout,
2727
allowGlobals,
2828
mustCall,
@@ -71,7 +71,7 @@ export {
7171
PIPE,
7272
hasIPv6,
7373
childShouldThrowAndAbort,
74-
ddCommand,
74+
createZeroFilledFile,
7575
platformTimeout,
7676
allowGlobals,
7777
mustCall,
Collapse file

‎test/parallel/test-http-chunk-problem.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-chunk-problem.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ function executeRequest(cb) {
6363

6464
tmpdir.refresh();
6565

66-
common.ddCommand(filename);
66+
common.createZeroFilledFile(filename);
6767

6868
server = http.createServer(function(req, res) {
6969
res.writeHead(200);
Collapse file

‎test/parallel/test-pipe-file-to-http.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-pipe-file-to-http.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ const server = http.createServer(function(req, res) {
5656
server.listen(0);
5757

5858
server.on('listening', function() {
59-
common.ddCommand(filename);
59+
common.createZeroFilledFile(filename);
6060
makeRequest();
6161
});
6262

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.