Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2d28978

Browse filesBrowse files
jasnellMylesBorins
authored andcommitted
fs: lazy load the promises impl
PR-URL: #20766 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent dc30d36 commit 2d28978
Copy full SHA for 2d28978

File tree

Expand file treeCollapse file tree

1 file changed

+7
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-4
lines changed
Open diff view settings
Collapse file

‎lib/fs.js‎

Copy file name to clipboardExpand all lines: lib/fs.js
+7-4Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ const { Readable, Writable } = require('stream');
6060
const EventEmitter = require('events');
6161
const { FSReqWrap, statValues, kFsStatsFieldsLength } = binding;
6262
const { FSEvent } = process.binding('fs_event_wrap');
63-
const promises = require('internal/fs/promises');
6463
const internalFS = require('internal/fs/utils');
6564
const { getPathFromURL } = require('internal/url');
6665
const internalUtil = require('internal/util');
@@ -89,14 +88,18 @@ const {
8988
CHAR_BACKWARD_SLASH,
9089
} = require('internal/constants');
9190

92-
let warn = true;
91+
// Lazy loaded
92+
let promises;
93+
94+
let promisesWarn = true;
9395

9496
Object.defineProperty(fs, 'promises', {
9597
configurable: true,
9698
enumerable: false,
9799
get() {
98-
if (warn) {
99-
warn = false;
100+
if (promisesWarn) {
101+
promises = require('internal/fs/promises');
102+
promisesWarn = false;
100103
process.emitWarning('The fs.promises API is experimental',
101104
'ExperimentalWarning');
102105
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.