Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2d0105c

Browse filesBrowse files
pipobscurecodebytere
authored andcommitted
net: remove unreachable check in internalConnect
Checked all call-sites to ensure that this code is truly unreachable. addressType is always checked before internalConnect is even called. PR-URL: #24158 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 672879f commit 2d0105c
Copy full SHA for 2d0105c

File tree

Expand file treeCollapse file tree

1 file changed

+1
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-4
lines changed
Open diff view settings
Collapse file

‎lib/net.js‎

Copy file name to clipboardExpand all lines: lib/net.js
+1-4Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -830,12 +830,9 @@ function internalConnect(
830830
if (addressType === 4) {
831831
localAddress = localAddress || '0.0.0.0';
832832
err = self._handle.bind(localAddress, localPort);
833-
} else if (addressType === 6) {
833+
} else { // addressType === 6
834834
localAddress = localAddress || '::';
835835
err = self._handle.bind6(localAddress, localPort);
836-
} else {
837-
self.destroy(new ERR_INVALID_ADDRESS_FAMILY(addressType));
838-
return;
839836
}
840837
debug('binding to localAddress: %s and localPort: %d (addressType: %d)',
841838
localAddress, localPort, addressType);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.