Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2cf8a7f

Browse filesBrowse files
pd4d10addaleax
authored andcommitted
module: fix specifier resolution algorithm
Fixes: #30520 PR-URL: #30574 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent 6c249c0 commit 2cf8a7f
Copy full SHA for 2cf8a7f

File tree

Expand file treeCollapse file tree

2 files changed

+26
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+26
-0
lines changed
Open diff view settings
Collapse file

‎lib/internal/modules/run_main.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/run_main.js
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ function shouldUseESMLoader(mainPath) {
2424
const userLoader = getOptionValue('--experimental-loader');
2525
if (userLoader)
2626
return true;
27+
const esModuleSpecifierResolution =
28+
getOptionValue('--es-module-specifier-resolution');
29+
if (esModuleSpecifierResolution === 'node')
30+
return true;
2731
// Determine the module format of the main
2832
if (mainPath && mainPath.endsWith('.mjs'))
2933
return true;
Collapse file

‎test/es-module/test-esm-specifiers.mjs‎

Copy file name to clipboardExpand all lines: test/es-module/test-esm-specifiers.mjs
+22Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// Flags: --es-module-specifier-resolution=node
22
import { mustNotCall } from '../common/index.mjs';
33
import assert from 'assert';
4+
import path from 'path';
5+
import { spawn } from 'child_process';
6+
import { fileURLToPath } from 'url';
47

58
// commonJS index.js
69
import commonjs from '../fixtures/es-module-specifiers/package-type-commonjs';
@@ -33,3 +36,22 @@ async function main() {
3336
}
3437

3538
main().catch(mustNotCall);
39+
40+
// Test path from command line arguments
41+
[
42+
'package-type-commonjs',
43+
'package-type-module',
44+
'/',
45+
'/index',
46+
].forEach((item) => {
47+
const modulePath = path.join(
48+
fileURLToPath(import.meta.url),
49+
'../../fixtures/es-module-specifiers',
50+
item,
51+
);
52+
spawn(process.execPath,
53+
['--es-module-specifier-resolution=node', modulePath],
54+
{ stdio: 'inherit' }).on('exit', (code) => {
55+
assert.strictEqual(code, 0);
56+
});
57+
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.