Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2cb4789

Browse filesBrowse files
pliabMylesBorins
pliab
authored and
MylesBorins
committed
test: corrected assertion arguments order
Fixed the order of expected arguments for assert.strictEqual() PR-URL: #23569 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent 110606d commit 2cb4789
Copy full SHA for 2cb4789

File tree

Expand file treeCollapse file tree

1 file changed

+73
-66
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+73
-66
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-util.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-util.js
+73-66Lines changed: 73 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -28,75 +28,75 @@ const errors = require('internal/errors');
2828
const context = require('vm').runInNewContext;
2929

3030
// isArray
31-
assert.strictEqual(true, util.isArray([]));
32-
assert.strictEqual(true, util.isArray(Array()));
33-
assert.strictEqual(true, util.isArray(new Array()));
34-
assert.strictEqual(true, util.isArray(new Array(5)));
35-
assert.strictEqual(true, util.isArray(new Array('with', 'some', 'entries')));
36-
assert.strictEqual(true, util.isArray(context('Array')()));
37-
assert.strictEqual(false, util.isArray({}));
38-
assert.strictEqual(false, util.isArray({ push: function() {} }));
39-
assert.strictEqual(false, util.isArray(/regexp/));
40-
assert.strictEqual(false, util.isArray(new Error()));
41-
assert.strictEqual(false, util.isArray(Object.create(Array.prototype)));
31+
assert.strictEqual(util.isArray([]), true);
32+
assert.strictEqual(util.isArray(Array()), true);
33+
assert.strictEqual(util.isArray(new Array()), true);
34+
assert.strictEqual(util.isArray(new Array(5)), true);
35+
assert.strictEqual(util.isArray(new Array('with', 'some', 'entries')), true);
36+
assert.strictEqual(util.isArray(context('Array')()), true);
37+
assert.strictEqual(util.isArray({}), false);
38+
assert.strictEqual(util.isArray({ push: function() {} }), false);
39+
assert.strictEqual(util.isArray(/regexp/), false);
40+
assert.strictEqual(util.isArray(new Error()), false);
41+
assert.strictEqual(util.isArray(Object.create(Array.prototype)), false);
4242

4343
// isRegExp
44-
assert.strictEqual(true, util.isRegExp(/regexp/));
45-
assert.strictEqual(true, util.isRegExp(RegExp(), 'foo'));
46-
assert.strictEqual(true, util.isRegExp(new RegExp()));
47-
assert.strictEqual(true, util.isRegExp(context('RegExp')()));
48-
assert.strictEqual(false, util.isRegExp({}));
49-
assert.strictEqual(false, util.isRegExp([]));
50-
assert.strictEqual(false, util.isRegExp(new Date()));
51-
assert.strictEqual(false, util.isRegExp(Object.create(RegExp.prototype)));
44+
assert.strictEqual(util.isRegExp(/regexp/), true);
45+
assert.strictEqual(util.isRegExp(RegExp(), 'foo'), true);
46+
assert.strictEqual(util.isRegExp(new RegExp()), true);
47+
assert.strictEqual(util.isRegExp(context('RegExp')()), true);
48+
assert.strictEqual(util.isRegExp({}), false);
49+
assert.strictEqual(util.isRegExp([]), false);
50+
assert.strictEqual(util.isRegExp(new Date()), false);
51+
assert.strictEqual(util.isRegExp(Object.create(RegExp.prototype)), false);
5252

5353
// isDate
54-
assert.strictEqual(true, util.isDate(new Date()));
55-
assert.strictEqual(true, util.isDate(new Date(0), 'foo'));
56-
assert.strictEqual(true, util.isDate(new (context('Date'))()));
57-
assert.strictEqual(false, util.isDate(Date()));
58-
assert.strictEqual(false, util.isDate({}));
59-
assert.strictEqual(false, util.isDate([]));
60-
assert.strictEqual(false, util.isDate(new Error()));
61-
assert.strictEqual(false, util.isDate(Object.create(Date.prototype)));
54+
assert.strictEqual(util.isDate(new Date()), true);
55+
assert.strictEqual(util.isDate(new Date(0), 'foo'), true);
56+
assert.strictEqual(util.isDate(new (context('Date'))()), true);
57+
assert.strictEqual(util.isDate(Date()), false);
58+
assert.strictEqual(util.isDate({}), false);
59+
assert.strictEqual(util.isDate([]), false);
60+
assert.strictEqual(util.isDate(new Error()), false);
61+
assert.strictEqual(util.isDate(Object.create(Date.prototype)), false);
6262

6363
// isError
64-
assert.strictEqual(true, util.isError(new Error()));
65-
assert.strictEqual(true, util.isError(new TypeError()));
66-
assert.strictEqual(true, util.isError(new SyntaxError()));
67-
assert.strictEqual(true, util.isError(new (context('Error'))()));
68-
assert.strictEqual(true, util.isError(new (context('TypeError'))()));
69-
assert.strictEqual(true, util.isError(new (context('SyntaxError'))()));
70-
assert.strictEqual(false, util.isError({}));
71-
assert.strictEqual(false, util.isError({ name: 'Error', message: '' }));
72-
assert.strictEqual(false, util.isError([]));
73-
assert.strictEqual(true, util.isError(Object.create(Error.prototype)));
64+
assert.strictEqual(util.isError(new Error()), true);
65+
assert.strictEqual(util.isError(new TypeError()), true);
66+
assert.strictEqual(util.isError(new SyntaxError()), true);
67+
assert.strictEqual(util.isError(new (context('Error'))()), true);
68+
assert.strictEqual(util.isError(new (context('TypeError'))()), true);
69+
assert.strictEqual(util.isError(new (context('SyntaxError'))()), true);
70+
assert.strictEqual(util.isError({}), false);
71+
assert.strictEqual(util.isError({ name: 'Error', message: '' }), false);
72+
assert.strictEqual(util.isError([]), false);
73+
assert.strictEqual(util.isError(Object.create(Error.prototype)), true);
7474

7575
// isObject
7676
assert.ok(util.isObject({}) === true);
7777

7878
// isPrimitive
79-
assert.strictEqual(false, util.isPrimitive({}));
80-
assert.strictEqual(false, util.isPrimitive(new Error()));
81-
assert.strictEqual(false, util.isPrimitive(new Date()));
82-
assert.strictEqual(false, util.isPrimitive([]));
83-
assert.strictEqual(false, util.isPrimitive(/regexp/));
84-
assert.strictEqual(false, util.isPrimitive(function() {}));
85-
assert.strictEqual(false, util.isPrimitive(new Number(1)));
86-
assert.strictEqual(false, util.isPrimitive(new String('bla')));
87-
assert.strictEqual(false, util.isPrimitive(new Boolean(true)));
88-
assert.strictEqual(true, util.isPrimitive(1));
89-
assert.strictEqual(true, util.isPrimitive('bla'));
90-
assert.strictEqual(true, util.isPrimitive(true));
91-
assert.strictEqual(true, util.isPrimitive(undefined));
92-
assert.strictEqual(true, util.isPrimitive(null));
93-
assert.strictEqual(true, util.isPrimitive(Infinity));
94-
assert.strictEqual(true, util.isPrimitive(NaN));
95-
assert.strictEqual(true, util.isPrimitive(Symbol('symbol')));
79+
assert.strictEqual(util.isPrimitive({}), false);
80+
assert.strictEqual(util.isPrimitive(new Error()), false);
81+
assert.strictEqual(util.isPrimitive(new Date()), false);
82+
assert.strictEqual(util.isPrimitive([]), false);
83+
assert.strictEqual(util.isPrimitive(/regexp/), false);
84+
assert.strictEqual(util.isPrimitive(function() {}), false);
85+
assert.strictEqual(util.isPrimitive(new Number(1)), false);
86+
assert.strictEqual(util.isPrimitive(new String('bla')), false);
87+
assert.strictEqual(util.isPrimitive(new Boolean(true)), false);
88+
assert.strictEqual(util.isPrimitive(1), true);
89+
assert.strictEqual(util.isPrimitive('bla'), true);
90+
assert.strictEqual(util.isPrimitive(true), true);
91+
assert.strictEqual(util.isPrimitive(undefined), true);
92+
assert.strictEqual(util.isPrimitive(null), true);
93+
assert.strictEqual(util.isPrimitive(Infinity), true);
94+
assert.strictEqual(util.isPrimitive(NaN), true);
95+
assert.strictEqual(util.isPrimitive(Symbol('symbol')), true);
9696

9797
// isBuffer
98-
assert.strictEqual(false, util.isBuffer('foo'));
99-
assert.strictEqual(true, util.isBuffer(Buffer.from('foo')));
98+
assert.strictEqual(util.isBuffer('foo'), false);
99+
assert.strictEqual(util.isBuffer(Buffer.from('foo')), true);
100100

101101
// _extend
102102
assert.deepStrictEqual(util._extend({ a: 1 }), { a: 1 });
@@ -160,18 +160,25 @@ util.error('test');
160160
assert.strictEqual(util.types.isNativeError(new Error()), true);
161161
assert.strictEqual(util.types.isNativeError(new TypeError()), true);
162162
assert.strictEqual(util.types.isNativeError(new SyntaxError()), true);
163-
assert.strictEqual(util.types.isNativeError(new (context('Error'))()),
164-
true);
165-
assert.strictEqual(util.types.isNativeError(new (context('TypeError'))()),
166-
true);
167-
assert.strictEqual(util.types.isNativeError(new (context('SyntaxError'))()),
168-
true);
163+
assert.strictEqual(util.types.isNativeError(new (context('Error'))()), true);
164+
assert.strictEqual(
165+
util.types.isNativeError(new (context('TypeError'))()),
166+
true
167+
);
168+
assert.strictEqual(
169+
util.types.isNativeError(new (context('SyntaxError'))()),
170+
true
171+
);
169172
assert.strictEqual(util.types.isNativeError({}), false);
170-
assert.strictEqual(util.types.isNativeError({ name: 'Error', message: '' }),
171-
false);
173+
assert.strictEqual(
174+
util.types.isNativeError({ name: 'Error', message: '' }),
175+
false
176+
);
172177
assert.strictEqual(util.types.isNativeError([]), false);
173-
assert.strictEqual(util.types.isNativeError(Object.create(Error.prototype)),
174-
false);
178+
assert.strictEqual(
179+
util.types.isNativeError(Object.create(Error.prototype)),
180+
false
181+
);
175182
assert.strictEqual(
176183
util.types.isNativeError(new errors.codes.ERR_IPC_CHANNEL_CLOSED()),
177184
true

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.