Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2c2e4a4

Browse filesBrowse files
lpincatargos
authored andcommitted
test: remove unnecessary code
The following tests - `test/parallel/test-https-client-renegotiation-limit.js` - `test/parallel/test-tls-alert-handling.js` - `test/parallel/test-tls-ocsp-callback.js` no longer use the OpenSSL CLI. Refs: #56714 (comment) PR-URL: #56784 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent fe00411 commit 2c2e4a4
Copy full SHA for 2c2e4a4

File tree

Expand file treeCollapse file tree

3 files changed

+0
-17
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+0
-17
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-https-client-renegotiation-limit.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-https-client-renegotiation-limit.js
-6Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ if (!common.hasCrypto) {
2525
common.skip('missing crypto');
2626
}
2727

28-
const { opensslCli } = require('../common/crypto');
29-
30-
if (!opensslCli) {
31-
common.skip('node compiled without OpenSSL CLI.');
32-
}
33-
3428
const assert = require('assert');
3529
const tls = require('tls');
3630
const https = require('https');
Collapse file

‎test/parallel/test-tls-alert-handling.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-alert-handling.js
-5Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,8 @@ if (!common.hasCrypto) {
88
const {
99
hasOpenSSL,
1010
hasOpenSSL3,
11-
opensslCli,
1211
} = require('../common/crypto');
1312

14-
if (!opensslCli) {
15-
common.skip('node compiled without OpenSSL CLI');
16-
}
17-
1813
const assert = require('assert');
1914
const net = require('net');
2015
const tls = require('tls');
Collapse file

‎test/parallel/test-tls-ocsp-callback.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-ocsp-callback.js
-6Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,6 @@ if (!common.hasCrypto) {
2626
common.skip('missing crypto');
2727
}
2828

29-
const { opensslCli } = require('../common/crypto');
30-
31-
if (!opensslCli) {
32-
common.skip('node compiled without OpenSSL CLI.');
33-
}
34-
3529
const crypto = require('crypto');
3630
const tls = require('tls');
3731
const fixtures = require('../common/fixtures');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.