Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2bf03ee

Browse filesBrowse files
joyeecheungmarco-ippolito
authored andcommitted
test: fix test-debugger-profile for coverage generation
The child process should not inherit NODE_V8_COVERAGE because that clobbers the inspector output the test is checking. PR-URL: #51816 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
1 parent d47a95f commit 2bf03ee
Copy full SHA for 2bf03ee

File tree

Expand file treeCollapse file tree

1 file changed

+8
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-debugger-profile.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-debugger-profile.js
+8-1Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,14 @@ function delay(ms) {
1414

1515
// Profiles.
1616
{
17-
const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')]);
17+
const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')], [], {
18+
env: {
19+
...process.env,
20+
// When this test is run with NODE_V8_COVERAGE, it clobbers the inspector
21+
// output, so override to disable coverage for the child process.
22+
NODE_V8_COVERAGE: undefined,
23+
}
24+
});
1825

1926
function onFatal(error) {
2027
cli.quit();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.