Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2b8a32a

Browse filesBrowse files
rvaggMyles Borins
authored andcommitted
src: refactor vcbuild configure args creation
remove a bunch of variables and rely on %configure_flags% where possible, also allow for an external %config_flags% variable to supply additional arguments to configure to match the behaviour of the Makefile PR-URL: #3399 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
1 parent 2b1804f commit 2b8a32a
Copy full SHA for 2b8a32a

File tree

Expand file treeCollapse file tree

1 file changed

+14
-14
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+14
-14
lines changed
Open diff view settings
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+14-14Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ if /i "%1"=="/?" goto help
1515
set config=Release
1616
set target=Build
1717
set target_arch=x86
18-
set debug_arg=
19-
set snapshot_arg=
2018
set noprojgen=
2119
set nobuild=
2220
set nosign=
@@ -28,15 +26,14 @@ set licensertf=
2826
set jslint=
2927
set buildnodeweak=
3028
set noetw=
31-
set noetw_arg=
3229
set noetw_msi_arg=
3330
set noperfctr=
34-
set noperfctr_arg=
3531
set noperfctr_msi_arg=
3632
set i18n_arg=
3733
set download_arg=
3834
set release_urls_arg=
3935
set build_release=
36+
set configure_flags=
4037

4138
:next-arg
4239
if "%1"=="" goto args-done
@@ -62,7 +59,6 @@ if /i "%1"=="test-internet" set test_args=%test_args% internet&goto arg-ok
6259
if /i "%1"=="test-pummel" set test_args=%test_args% pummel&goto arg-ok
6360
if /i "%1"=="test-all" set test_args=%test_args% sequential parallel message gc internet pummel&set buildnodeweak=1&set jslint=1&goto arg-ok
6461
if /i "%1"=="jslint" set jslint=1&goto arg-ok
65-
@rem Include small-icu support with MSI installer
6662
if /i "%1"=="msi" set msi=1&set licensertf=1&set download_arg="--download=all"&set i18n_arg=small-icu&goto arg-ok
6763
if /i "%1"=="build-release" set build_release=1&goto arg-ok
6864
if /i "%1"=="upload" set upload=1&goto arg-ok
@@ -89,15 +85,18 @@ if defined build_release (
8985
set i18n_arg=small-icu
9086
)
9187

92-
if "%config%"=="Debug" set debug_arg=--debug
93-
if defined nosnapshot set snapshot_arg=--without-snapshot
94-
if defined noetw set noetw_arg=--without-etw& set noetw_msi_arg=/p:NoETW=1
95-
if defined noperfctr set noperfctr_arg=--without-perfctr& set noperfctr_msi_arg=/p:NoPerfCtr=1
96-
if defined RELEASE_URLBASE set release_urlbase_arg=--release-urlbase=%RELEASE_URLBASE%
88+
if "%config%"=="Debug" set configure_flags=%configure_flags% --debug
89+
if defined nosnapshot set configure_flags=%configure_flags% --without-snapshot
90+
if defined noetw set configure_flags=%configure_flags% --without-etw& set noetw_msi_arg=/p:NoETW=1
91+
if defined noperfctr set configure_flags=%configure_flags% --without-perfctr& set noperfctr_msi_arg=/p:NoPerfCtr=1
92+
if defined release_urlbase set release_urlbase_arg=--release-urlbase=%release_urlbase%
93+
if defined download_arg set configure_flags=%configure_flags% %download_arg%
9794

98-
if "%i18n_arg%"=="full-icu" set i18n_arg=--with-intl=full-icu
99-
if "%i18n_arg%"=="small-icu" set i18n_arg=--with-intl=small-icu
100-
if "%i18n_arg%"=="intl-none" set i18n_arg=--with-intl=none
95+
if "%i18n_arg%"=="full-icu" set configure_flags=%configure_flags% --with-intl=full-icu
96+
if "%i18n_arg%"=="small-icu" set configure_flags=%configure_flags% --with-intl=small-icu
97+
if "%i18n_arg%"=="intl-none" set configure_flags=%configure_flags% --with-intl=none
98+
99+
if defined config_flags set configure_flags=%configure_flags% %config_flags%
101100

102101
if not exist "%~dp0deps\icu" goto no-depsicu
103102
if "%target%"=="Clean" echo deleting %~dp0deps\icu
@@ -168,7 +167,8 @@ goto run
168167
if defined noprojgen goto msbuild
169168

170169
@rem Generate the VS project.
171-
python configure %download_arg% %i18n_arg% %debug_arg% %snapshot_arg% %noetw_arg% %noperfctr_arg% --dest-cpu=%target_arch% --tag=%TAG%
170+
echo configure %configure_flags% --dest-cpu=%target_arch% --tag=%TAG%
171+
python configure %configure_flags% --dest-cpu=%target_arch% --tag=%TAG%
172172
if errorlevel 1 goto create-msvs-files-failed
173173
if not exist node.sln goto create-msvs-files-failed
174174
echo Project files generated.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.