Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2b7273b

Browse filesBrowse files
Trottaddaleax
authored andcommitted
crypto: improve invalid arg type message for randomInt()
Use "must be a safe integer" rather than "must be safe integer". I believe the former is more easily understood/clear. PR-URL: #35089 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent bf5a85b commit 2b7273b
Copy full SHA for 2b7273b

File tree

Expand file treeCollapse file tree

2 files changed

+6
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-6
lines changed
Open diff view settings
Collapse file

‎lib/internal/crypto/random.js‎

Copy file name to clipboardExpand all lines: lib/internal/crypto/random.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,10 @@ function randomInt(min, max, callback) {
144144
throw new ERR_INVALID_CALLBACK(callback);
145145
}
146146
if (!NumberIsSafeInteger(min)) {
147-
throw new ERR_INVALID_ARG_TYPE('min', 'safe integer', min);
147+
throw new ERR_INVALID_ARG_TYPE('min', 'a safe integer', min);
148148
}
149149
if (!NumberIsSafeInteger(max)) {
150-
throw new ERR_INVALID_ARG_TYPE('max', 'safe integer', max);
150+
throw new ERR_INVALID_ARG_TYPE('max', 'a safe integer', max);
151151
}
152152
if (max <= min) {
153153
throw new ERR_OUT_OF_RANGE(
Collapse file

‎test/parallel/test-crypto-random.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-crypto-random.js
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -394,13 +394,13 @@ assert.throws(
394394
const invalidMinError = {
395395
code: 'ERR_INVALID_ARG_TYPE',
396396
name: 'TypeError',
397-
message: 'The "min" argument must be safe integer.' +
397+
message: 'The "min" argument must be a safe integer.' +
398398
`${common.invalidArgTypeHelper(i)}`,
399399
};
400400
const invalidMaxError = {
401401
code: 'ERR_INVALID_ARG_TYPE',
402402
name: 'TypeError',
403-
message: 'The "max" argument must be safe integer.' +
403+
message: 'The "max" argument must be a safe integer.' +
404404
`${common.invalidArgTypeHelper(i)}`,
405405
};
406406

@@ -441,7 +441,7 @@ assert.throws(
441441
{
442442
code: 'ERR_INVALID_ARG_TYPE',
443443
name: 'TypeError',
444-
message: 'The "min" argument must be safe integer.' +
444+
message: 'The "min" argument must be a safe integer.' +
445445
`${common.invalidArgTypeHelper(minInt - 1)}`,
446446
}
447447
);
@@ -451,7 +451,7 @@ assert.throws(
451451
{
452452
code: 'ERR_INVALID_ARG_TYPE',
453453
name: 'TypeError',
454-
message: 'The "max" argument must be safe integer.' +
454+
message: 'The "max" argument must be a safe integer.' +
455455
`${common.invalidArgTypeHelper(maxInt + 1)}`,
456456
}
457457
);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.