Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2ab3fcc

Browse filesBrowse files
Trottaddaleax
authored andcommitted
test: fix test-net-pingpong pummel test for non-IPv6 hosts
Use `common.hasIPv6` instead of an OS check for more reliable operation. PR-URL: #34359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 7c7d3e3 commit 2ab3fcc
Copy full SHA for 2ab3fcc

File tree

Expand file treeCollapse file tree

1 file changed

+2
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-3
lines changed
Open diff view settings
Collapse file

‎test/pummel/test-net-pingpong.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-net-pingpong.js
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,8 @@ function pingPongTest(host, on_complete) {
113113
pingPongTest('localhost');
114114
pingPongTest(null);
115115

116-
// This IPv6 isn't working on Solaris.
117-
if (!common.isSunOS) pingPongTest('::1');
116+
if (common.hasIPv6) pingPongTest('::1');
118117

119118
process.on('exit', function() {
120-
assert.strictEqual(tests_run, common.isSunOS ? 2 : 3);
119+
assert.strictEqual(tests_run, common.hasIPv6 ? 3 : 2);
121120
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.