Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 297cb0d

Browse filesBrowse files
mhdawsontargos
authored andcommitted
doc: tweak onboarding instructions
Add some additional guidance based on something we missed in a recent onboarding step. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #55212 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com>
1 parent 1b30f7f commit 297cb0d
Copy full SHA for 297cb0d

File tree

Expand file treeCollapse file tree

1 file changed

+7
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-0
lines changed
Open diff view settings
Collapse file

‎onboarding.md‎

Copy file name to clipboardExpand all lines: onboarding.md
+7Lines changed: 7 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,13 @@ needs to be pointed out separately during the onboarding.
216216
`git show --format=%B 6669b3857f0f43ee0296eb7ac45086cd907b9e94`
217217
* Collaborators are in alphabetical order by GitHub username.
218218
* Optionally, include your personal pronouns.
219+
* The PR should include an addition to the
220+
[mailmap](.mailmap) file if the email
221+
being added to the collaborator list does not match the email used for
222+
commits. Otherwise tooling will not see the collaborator as being active and
223+
may suggest removing them. See
224+
[gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the
225+
format of the mailmap file.
219226
* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
220227
so that when the commit lands, the nomination issue url will be
221228
automatically closed.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.