Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 295eb5a

Browse filesBrowse files
pmasucciaddaleax
authored andcommitted
test: swap var->const/let and equal->strictEqual
Change instances of var with const/let. Change assert.equal to assert.strictEqual. PR-URL: #9888 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 57f060c commit 295eb5a
Copy full SHA for 295eb5a

File tree

Expand file treeCollapse file tree

1 file changed

+15
-15
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+15
-15
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-tls-no-sslv3.js‎

Copy file name to clipboard
+15-15Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,45 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
2+
const common = require('../common');
3+
const assert = require('assert');
44

55
if (!common.hasCrypto) {
66
common.skip('missing crypto');
77
return;
88
}
9-
var tls = require('tls');
9+
const tls = require('tls');
1010

11-
var fs = require('fs');
12-
var spawn = require('child_process').spawn;
11+
const fs = require('fs');
12+
const spawn = require('child_process').spawn;
1313

1414
if (common.opensslCli === false) {
1515
common.skip('node compiled without OpenSSL CLI.');
1616
return;
1717
}
1818

19-
var cert = fs.readFileSync(common.fixturesDir + '/test_cert.pem');
20-
var key = fs.readFileSync(common.fixturesDir + '/test_key.pem');
21-
var server = tls.createServer({ cert: cert, key: key }, common.fail);
22-
var errors = [];
23-
var stderr = '';
19+
const cert = fs.readFileSync(common.fixturesDir + '/test_cert.pem');
20+
const key = fs.readFileSync(common.fixturesDir + '/test_key.pem');
21+
const server = tls.createServer({ cert: cert, key: key }, common.fail);
22+
const errors = [];
23+
let stderr = '';
2424

2525
server.listen(0, '127.0.0.1', function() {
26-
var address = this.address().address + ':' + this.address().port;
27-
var args = ['s_client',
26+
const address = this.address().address + ':' + this.address().port;
27+
const args = ['s_client',
2828
'-ssl3',
2929
'-connect', address];
3030

3131
// for the performance and stability issue in s_client on Windows
3232
if (common.isWindows)
3333
args.push('-no_rand_screen');
3434

35-
var client = spawn(common.opensslCli, args, { stdio: 'pipe' });
35+
const client = spawn(common.opensslCli, args, { stdio: 'pipe' });
3636
client.stdout.pipe(process.stdout);
3737
client.stderr.pipe(process.stderr);
3838
client.stderr.setEncoding('utf8');
3939
client.stderr.on('data', (data) => stderr += data);
4040

4141
client.once('exit', common.mustCall(function(exitCode) {
42-
assert.equal(exitCode, 1);
42+
assert.strictEqual(exitCode, 1);
4343
server.close();
4444
}));
4545
});
@@ -50,7 +50,7 @@ process.on('exit', function() {
5050
if (/unknown option -ssl3/.test(stderr)) {
5151
common.skip('`openssl s_client -ssl3` not supported.');
5252
} else {
53-
assert.equal(errors.length, 1);
53+
assert.strictEqual(errors.length, 1);
5454
assert(/:wrong version number/.test(errors[0].message));
5555
}
5656
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.