Commit 295d1ea
util: support classes in util.deprecate()
Classes cannot be instantiated without new, but util.deprecate()
uses Function.prototype.apply(). This commit uses new.target to
detect constructor calls, allowing classes to be deprecated.
PR-URL: #7690
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent df35ae6 commit 295d1eaCopy full SHA for 295d1ea
File tree
Expand file treeCollapse file tree
5 files changed
+62
-4
lines changedOpen diff view settings
Filter options
- doc/api
- lib/internal
- test
- fixtures
- sequential
Expand file treeCollapse file tree
5 files changed
+62
-4
lines changedOpen diff view settings
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
46 | 46 | |
47 | 47 | |
48 | 48 | |
49 | | - |
| 49 | + |
50 | 50 | |
51 | 51 | |
52 | 52 | |
|
Collapse file
+9Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
57 | 57 | |
58 | 58 | |
59 | 59 | |
| 60 | + |
| 61 | + |
| 62 | + |
60 | 63 | |
61 | 64 | |
62 | 65 | |
| 66 | + |
| 67 | + |
| 68 | + |
| 69 | + |
| 70 | + |
| 71 | + |
63 | 72 | |
64 | 73 | |
65 | 74 | |
|
Collapse file
test/fixtures/deprecated-userland-class.js
Copy file name to clipboard+12Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
Collapse file
test/fixtures/deprecated-userland-subclass.js
Copy file name to clipboard+19Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
Collapse file
test/sequential/test-deprecation-flags.js
Copy file name to clipboardExpand all lines: test/sequential/test-deprecation-flags.js+21-3Lines changed: 21 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
5 | 5 | |
6 | 6 | |
7 | 7 | |
8 | | - |
9 | | - |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
10 | 16 | |
11 | 17 | |
12 | 18 | |
| ||
39 | 45 | |
40 | 46 | |
41 | 47 | |
42 | | - |
| 48 | + |
43 | 49 | |
44 | 50 | |
45 | 51 | |
46 | 52 | |
47 | 53 | |
48 | 54 | |
| 55 | + |
| 56 | + |
| 57 | + |
| 58 | + |
| 59 | + |
| 60 | + |
| 61 | + |
| 62 | + |
| 63 | + |
| 64 | + |
| 65 | + |
| 66 | + |
0 commit comments