Commit 28ed7d0
http2: centralise socket event binding in Http2Session
Move the socket event binding to the
HTTP2Session constructor so that an error
event could be delivered should the
constructor fail
Ref: #35772
PR-URL: #35772
Fixes: #35695
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>1 parent 429113e commit 28ed7d0Copy full SHA for 28ed7d0
File tree
Expand file treeCollapse file tree
2 files changed
+5
-12
lines changedOpen diff view settings
Filter options
- lib/internal/http2
- test/parallel
Expand file treeCollapse file tree
2 files changed
+5
-12
lines changedOpen diff view settings
Collapse file
+2-9Lines changed: 2 additions & 9 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1129 | 1129 | |
1130 | 1130 | |
1131 | 1131 | |
| 1132 | + |
| 1133 | + |
1132 | 1134 | |
1133 | 1135 | |
1134 | 1136 | |
| ||
2909 | 2911 | |
2910 | 2912 | |
2911 | 2913 | |
2912 | | - |
2913 | | - |
2914 | | - |
2915 | 2914 | |
2916 | 2915 | |
2917 | 2916 | |
| ||
3134 | 3133 | |
3135 | 3134 | |
3136 | 3135 | |
3137 | | - |
3138 | | - |
3139 | | - |
3140 | | - |
3141 | | - |
3142 | | - |
3143 | 3136 | |
3144 | 3137 | |
3145 | 3138 | |
|
Collapse file
test/parallel/test-http2-client-jsstream-destroy.js
Copy file name to clipboardExpand all lines: test/parallel/test-http2-client-jsstream-destroy.js+3-3Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
46 | 46 | |
47 | 47 | |
48 | 48 | |
49 | | - |
50 | | - |
51 | | - |
| 49 | + |
| 50 | + |
| 51 | + |
52 | 52 | |
53 | 53 | |
54 | 54 | |
|
0 commit comments