Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 28a5ce1

Browse filesBrowse files
edsadrMylesBorins
authored andcommitted
test: improve test-http-allow-req-after-204-res
* use const instead of var * use common.mustCall to control functions execution * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: #10503 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent c7378c4 commit 28a5ce1
Copy full SHA for 28a5ce1

File tree

Expand file treeCollapse file tree

1 file changed

+15
-18
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+15
-18
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-http-allow-req-after-204-res.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-allow-req-after-204-res.js
+15-18Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,42 @@
11
'use strict';
2-
require('../common');
3-
var http = require('http');
4-
var assert = require('assert');
2+
const common = require('../common');
3+
const http = require('http');
4+
const assert = require('assert');
55

66
// first 204 or 304 works, subsequent anything fails
7-
var codes = [204, 200];
7+
const codes = [204, 200];
88

99
// Methods don't really matter, but we put in something realistic.
10-
var methods = ['DELETE', 'DELETE'];
10+
const methods = ['DELETE', 'DELETE'];
1111

12-
var server = http.createServer(function(req, res) {
13-
var code = codes.shift();
14-
assert.equal('number', typeof code);
12+
const server = http.createServer(common.mustCall((req, res) => {
13+
const code = codes.shift();
14+
assert.strictEqual(typeof code, 'number');
1515
assert.ok(code > 0);
16-
console.error('writing %d response', code);
1716
res.writeHead(code, {});
1817
res.end();
19-
});
18+
}, codes.length));
2019

2120
function nextRequest() {
22-
var method = methods.shift();
23-
console.error('writing request: %s', method);
21+
const method = methods.shift();
2422

25-
var request = http.request({
23+
const request = http.request({
2624
port: server.address().port,
2725
method: method,
2826
path: '/'
29-
}, function(response) {
30-
response.on('end', function() {
27+
}, common.mustCall((response) => {
28+
response.on('end', common.mustCall(() => {
3129
if (methods.length === 0) {
32-
console.error('close server');
3330
server.close();
3431
} else {
3532
// throws error:
3633
nextRequest();
3734
// works just fine:
3835
//process.nextTick(nextRequest);
3936
}
40-
});
37+
}));
4138
response.resume();
42-
});
39+
}));
4340
request.end();
4441
}
4542

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.