Commit 275907f
test: fix flaky http2-session-unref
It's possible for the connections to take too long and since the server
is already unrefed, the process will just exit. Instead adjust the test
so that server unref only happens after all sessions have been
successfuly established and unrefed. That still tests the same condition
but will not fail under load.
PR-URL: #20772
Fixes: #20705
Fixes: #20750
Fixes: #20850
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 171600d commit 275907fCopy full SHA for 275907f
File tree
Expand file treeCollapse file tree
1 file changed
+4
-1
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+4
-1
lines changedOpen diff view settings
Collapse file
test/parallel/test-http2-session-unref.js
Copy file name to clipboardExpand all lines: test/parallel/test-http2-session-unref.js+4-1Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
9 | 9 | |
10 | 10 | |
11 | 11 | |
| 12 | + |
12 | 13 | |
13 | 14 | |
14 | 15 | |
15 | 16 | |
16 | 17 | |
| 18 | + |
| 19 | + |
17 | 20 | |
18 | 21 | |
19 | 22 | |
20 | 23 | |
21 | 24 | |
| 25 | + |
22 | 26 | |
23 | 27 | |
24 | 28 | |
| ||
54 | 58 | |
55 | 59 | |
56 | 60 | |
57 | | - |
|
0 commit comments