nodejs
diff --git a/Collapse file
‎lib/_stream_readable.js‎
Copy file name to clipboardExpand all lines: lib/_stream_readable.js
+1-1Lines changed: 1 addition & 1 deletion b/Collapse file
‎lib/_stream_readable.js‎
Copy file name to clipboardExpand all lines: lib/_stream_readable.js
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/Collapse file
‎test/parallel/test-stream-pipe-unpipe-streams.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-stream-pipe-unpipe-streams.js
+54Lines changed: 54 additions & 0 deletions b/Collapse file
‎test/parallel/test-stream-pipe-unpipe-streams.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-stream-pipe-unpipe-streams.js
+54Lines changed: 54 additions & 0 deletions
@@ -754,7 +754,7 @@ Readable.prototype.unpipe = function(dest) {
     state.flowing = false;
 
     for (var i = 0; i < len; i++)
-      dests[i].emit('unpipe', this, unpipeInfo);
+      dests[i].emit('unpipe', this, { hasUnpiped: false });
     return this;
   }
 
 
@@ -31,3 +31,57 @@ source.unpipe(dest2);
 source.unpipe(dest1);
 
 assert.strictEqual(source._readableState.pipes, null);
+
+{
+  // test `cleanup()` if we unpipe all streams.
+  const source = Readable({ read: () => {} });
+  const dest1 = Writable({ write: () => {} });
+  const dest2 = Writable({ write: () => {} });
+
+  let destCount = 0;
+  const srcCheckEventNames = ['end', 'data'];
+  const destCheckEventNames = ['close', 'finish', 'drain', 'error', 'unpipe'];
+
+  const checkSrcCleanup = common.mustCall(() => {
+    assert.strictEqual(source._readableState.pipes, null);
+    assert.strictEqual(source._readableState.pipesCount, 0);
+    assert.strictEqual(source._readableState.flowing, false);
+
+    srcCheckEventNames.forEach((eventName) => {
+      assert.strictEqual(
+        source.listenerCount(eventName), 0,
+        `source's '${eventName}' event listeners not removed`
+      );
+    });
+  });
+
+  function checkDestCleanup(dest) {
+    const currentDestId = ++destCount;
+    source.pipe(dest);
+
+    const unpipeChecker = common.mustCall(() => {
+      assert.deepStrictEqual(
+        dest.listeners('unpipe'), [unpipeChecker],
+        `destination{${currentDestId}} should have a 'unpipe' event ` +
+        'listener which is `unpipeChecker`'
+      );
+      dest.removeListener('unpipe', unpipeChecker);
+      destCheckEventNames.forEach((eventName) => {
+        assert.strictEqual(
+          dest.listenerCount(eventName), 0,
+          `destination{${currentDestId}}'s '${eventName}' event ` +
+          'listeners not removed'
+        );
+      });
+
+      if (--destCount === 0)
+        checkSrcCleanup();
+    });
+
+    dest.on('unpipe', unpipeChecker);
+  }
+
+  checkDestCleanup(dest1);
+  checkDestCleanup(dest2);
+  source.unpipe();
+}
Original file line number	Diff line number	Diff line change
`@@ -754,7 +754,7 @@ Readable.prototype.unpipe = function(dest) {`
`754`	`754`	`state.flowing = false;`
`755`	`755`
`756`	`756`	`for (var i = 0; i < len; i++)`
`757`		`- dests[i].emit('unpipe', this, unpipeInfo);`
	`757`	`+ dests[i].emit('unpipe', this, { hasUnpiped: false });`
`758`	`758`	`return this;`
`759`	`759`	`}`
`760`	`760`