Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 26fcc7a

Browse filesBrowse files
addaleaxMylesBorins
authored andcommitted
doc: s/origin/upstream/ collaborator guide
Use `upstream` to refer to `nodejs/node` instead of `origin`, because that’s the more common setup. PR-URL: #12436 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 0caca45 commit 26fcc7a
Copy full SHA for 26fcc7a

File tree

Expand file treeCollapse file tree

1 file changed

+8
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-7
lines changed
Open diff view settings
Collapse file

‎COLLABORATOR_GUIDE.md‎

Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md
+8-7Lines changed: 8 additions & 7 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -358,11 +358,12 @@ Checkout proper target branch
358358
$ git checkout master
359359
```
360360

361-
Update the tree
361+
Update the tree (assumes your repo is set up as detailed in
362+
[CONTRIBUTING.md](CONTRIBUTING.md#step-1-fork))
362363

363364
```text
364-
$ git fetch origin
365-
$ git merge --ff-only origin/master
365+
$ git fetch upstream
366+
$ git merge --ff-only upstream/master
366367
```
367368

368369
Apply external patches
@@ -374,21 +375,21 @@ $ curl -L https://github.com/nodejs/node/pull/xxx.patch | git am --whitespace=fi
374375
Check and re-review the changes
375376

376377
```text
377-
$ git diff origin/master
378+
$ git diff upstream/master
378379
```
379380

380381
Check number of commits and commit messages
381382

382383
```text
383-
$ git log origin/master...master
384+
$ git log upstream/master...master
384385
```
385386

386387
If there are multiple commits that relate to the same feature or
387388
one with a feature and separate with a test for that feature,
388389
you'll need to use `squash` or `fixup`:
389390

390391
```text
391-
$ git rebase -i origin/master
392+
$ git rebase -i upstream/master
392393
```
393394

394395
This will open a screen like this (in the default shell editor):
@@ -447,7 +448,7 @@ commit logs, ensure that they are properly formatted, and add
447448
Time to push it:
448449

449450
```text
450-
$ git push origin master
451+
$ git push upstream master
451452
```
452453
* Optional: Force push the amended commit to the branch you used to
453454
open the pull request. If your branch is called `bugfix`, then the

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.