Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 25f93f3

Browse filesBrowse files
addaleaxruyadorno
addaleax
authored and
ruyadorno
committed
test: add more valid results to test-trace-atomics-wait
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: #35059 PR-URL: #35066 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent fb89be6 commit 25f93f3
Copy full SHA for 25f93f3

File tree

Expand file treeCollapse file tree

1 file changed

+12
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+12
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-trace-atomics-wait.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-trace-atomics-wait.js
+12-1Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,11 @@ const expectedTimelines = [
5454
[Thread 0] Atomics.wait(<address> + 4, 0, inf) started
5555
[Thread 1] Atomics.wait(<address> + 4, -1, inf) started
5656
[Thread 0] Atomics.wait(<address> + 4, 0, inf) was woken up by another thread
57+
[Thread 1] Atomics.wait(<address> + 4, -1, inf) was woken up by another thread`,
58+
`${begin}
59+
[Thread 1] Atomics.wait(<address> + 4, 0, inf) started
60+
[Thread 0] Atomics.wait(<address> + 4, -1, inf) started
61+
[Thread 0] Atomics.wait(<address> + 4, 0, inf) was woken up by another thread
5762
[Thread 1] Atomics.wait(<address> + 4, -1, inf) was woken up by another thread`,
5863
`${begin}
5964
[Thread 0] Atomics.wait(<address> + 4, 0, inf) started
@@ -71,14 +76,20 @@ values mismatched`,
7176
[Thread 1] Atomics.wait(<address> + 4, -1, inf) started
7277
[Thread 0] Atomics.wait(<address> + 4, 0, inf) was woken up by another thread
7378
[Thread 1] Atomics.wait(<address> + 4, -1, inf) did not wait because the \
79+
values mismatched`,
80+
`${begin}
81+
[Thread 1] Atomics.wait(<address> + 4, 0, inf) started
82+
[Thread 0] Atomics.wait(<address> + 4, -1, inf) started
83+
[Thread 0] Atomics.wait(<address> + 4, 0, inf) was woken up by another thread
84+
[Thread 1] Atomics.wait(<address> + 4, -1, inf) did not wait because the \
7485
values mismatched`,
7586
`${begin}
7687
[Thread 0] Atomics.wait(<address> + 4, 0, inf) started
7788
[Thread 0] Atomics.wait(<address> + 4, 0, inf) did not wait because the \
7889
values mismatched
7990
[Thread 1] Atomics.wait(<address> + 4, -1, inf) started
8091
[Thread 1] Atomics.wait(<address> + 4, -1, inf) did not wait because the \
81-
values mismatched`
92+
values mismatched`,
8293
];
8394

8495
assert(expectedTimelines.includes(actualTimeline));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.