Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 259f2d3

Browse filesBrowse files
TrottMylesBorins
authored andcommitted
test: remove fixturesDir from common module
Remove common.fixturesDir. All tests now use the the common/fixtures module instead. PR-URL: #17400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 92b29cd commit 259f2d3
Copy full SHA for 259f2d3

File tree

Expand file treeCollapse file tree

2 files changed

+1
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+1
-8
lines changed
Open diff view settings
Collapse file

‎test/common/README.md‎

Copy file name to clipboardExpand all lines: test/common/README.md
-5Lines changed: 0 additions & 5 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,6 @@ Returns a new promise that will propagate `promise` resolution or rejection if
127127
that happens within the `timeoutMs` timespan, or rejects with `error` as
128128
a reason otherwise.
129129

130-
### fixturesDir
131-
* [&lt;String>]
132-
133-
Path to the 'fixtures' directory.
134-
135130
### getArrayBufferViews(buf)
136131
* `buf` [&lt;Buffer>]
137132
* return [&lt;ArrayBufferView&#91;&#93;>]
Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ const testRoot = process.env.NODE_TEST_DIR ?
3636

3737
const noop = () => {};
3838

39-
exports.fixturesDir = fixturesDir;
40-
4139
// Using a `.` prefixed name, which is the convention for "hidden" on POSIX,
4240
// gets tools to ignore it by default or by simple rules, especially eslint.
4341
let tmpDirName = '.tmp';
@@ -303,7 +301,7 @@ exports.childShouldThrowAndAbort = function() {
303301

304302
exports.ddCommand = function(filename, kilobytes) {
305303
if (exports.isWindows) {
306-
const p = path.resolve(exports.fixturesDir, 'create-file.js');
304+
const p = path.resolve(fixturesDir, 'create-file.js');
307305
return `"${process.argv[0]}" "${p}" "${filename}" ${kilobytes * 1024}`;
308306
} else {
309307
return `dd if=/dev/zero of="${filename}" bs=1024 count=${kilobytes}`;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.