Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 255f177

Browse filesBrowse files
deokjinkimRafaelGSS
authored andcommitted
test: enable more case of bad buffer in fs.write
Passing to the `string` parameter an object with an own `toString` function is no longer supported.(DEP0162) So use such case as bad buffer in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/deprecations.md#dep0162-fswrite-fswritefilesync-coercion-to-string PR-URL: #46236 Refs: #42796 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent c09b203 commit 255f177
Copy full SHA for 255f177

File tree

Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-fs-write-optional-params.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-write-optional-params.js
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,7 @@ async function runTests(fd) {
6868
new Date(),
6969
new String('notPrimitive'),
7070
{ [Symbol.toPrimitive]: (hint) => 'amObject' },
71-
72-
// TODO(LiviaMedeiros): add the following after DEP0162 EOL
73-
// { toString() { return 'amObject'; } },
71+
{ toString() { return 'amObject'; } },
7472
]) {
7573
await testInvalid(fd, 'ERR_INVALID_ARG_TYPE', badBuffer, {});
7674
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.