Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2498e29

Browse filesBrowse files
silverwindFishrock123
authored andcommitted
src: Revert "nix stdin _readableState.reading"
This reverts 8cee8f5 which was causing stdin to behave strangely on Windows 8 and 10. The suspected explanation for the issue is that there might be a race condition occuring when stdin._readableState.reading is set indirectly through `push('')`. PR-URL: #3490 Fixes: #2996 Fixes: #2504 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
1 parent b663d2b commit 2498e29
Copy full SHA for 2498e29

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎src/node.js‎

Copy file name to clipboardExpand all lines: src/node.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -726,7 +726,7 @@
726726
// not-reading state.
727727
if (stdin._handle && stdin._handle.readStop) {
728728
stdin._handle.reading = false;
729-
stdin.push('');
729+
stdin._readableState.reading = false;
730730
stdin._handle.readStop();
731731
}
732732

@@ -735,7 +735,7 @@
735735
stdin.on('pause', function() {
736736
if (!stdin._handle)
737737
return;
738-
stdin.push('');
738+
stdin._readableState.reading = false;
739739
stdin._handle.reading = false;
740740
stdin._handle.readStop();
741741
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.