Commit 236491e
build: update build-addons when node-gyp changes
Backported from
99bf6fa
We can tell when `node-gyp` is changed by creating a prerequisite on
`deps/npm/node_modules/node-gyp/package.json`. The prerequisite is added
to the `test/addons/.buildstamp` since `build-addons` is .PHONY.
Testing for this change was entirely manual.
$ make clean test-build # Initial build
$ make test-build # Make sure build-addons doesn't rebuild
$ touch deps/npm/node_modules/node-gyp/package.json # simulate change
$ make test-build # Ensure build-addons rebuilds
PR-URL: #6787
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 9a8acad commit 236491eCopy full SHA for 236491e
File tree
Expand file treeCollapse file tree
1 file changed
+5
-2
lines changedOpen diff view settings
Filter options
Expand file treeCollapse file tree
1 file changed
+5
-2
lines changedOpen diff view settings
Collapse file
+5-2Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
138 | 138 | |
139 | 139 | |
140 | 140 | |
141 | | - |
| 141 | + |
| 142 | + |
| 143 | + |
| 144 | + |
142 | 145 | |
143 | 146 | |
144 | 147 | |
| ||
154 | 157 | |
155 | 158 | |
156 | 159 | |
157 | | - |
| 160 | + |
158 | 161 | |
159 | 162 | |
160 | 163 | |
|
0 commit comments