Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 231ef4b

Browse filesBrowse files
Trotttargos
Trott
authored and
targos
committed
test: move slower tests into pummel and skip on slow devices
Move slower tests to pummel and skip on Raspberry Pi devices in CI. Refs: #34289 (comment) PR-URL: #38395 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent 45322df commit 231ef4b
Copy full SHA for 231ef4b
Expand file treeCollapse file tree

5 files changed

+38
-5
lines changed
Open diff view settings
Collapse file

‎test/pummel/test-fs-watch-system-limit.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-fs-watch-system-limit.js
+10-2Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,18 @@ const child_process = require('child_process');
55
const fs = require('fs');
66
const stream = require('stream');
77

8-
if (!common.isLinux)
8+
if (!common.isLinux) {
99
common.skip('The fs watch limit is OS-dependent');
10-
if (!common.enoughTestCpu)
10+
}
11+
12+
if (!common.enoughTestCpu) {
1113
common.skip('This test is resource-intensive');
14+
}
15+
16+
if ((process.config.variables.arm_version === '6') ||
17+
(process.config.variables.arm_version === '7')) {
18+
common.skip('Too slow for armv6 and armv7 bots');
19+
}
1220

1321
try {
1422
// Ensure inotify limit is low enough for the test to actually exercise the
Collapse file

‎…-heapsnapshot-near-heap-limit-bounded.js‎ ‎…-heapsnapshot-near-heap-limit-bounded.js‎test/parallel/test-heapsnapshot-near-heap-limit-bounded.js renamed to test/pummel/test-heapsnapshot-near-heap-limit-bounded.js test/parallel/test-heapsnapshot-near-heap-limit-bounded.js renamed to test/pummel/test-heapsnapshot-near-heap-limit-bounded.js

Copy file name to clipboardExpand all lines: test/pummel/test-heapsnapshot-near-heap-limit-bounded.js
+7-1Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
'use strict';
22

3-
require('../common');
3+
const common = require('../common');
4+
5+
if ((process.config.variables.arm_version === '6') ||
6+
(process.config.variables.arm_version === '7')) {
7+
common.skip('Too slow for armv6 and armv7 bots');
8+
}
9+
410
const tmpdir = require('../common/tmpdir');
511
const assert = require('assert');
612
const { spawnSync } = require('child_process');
Collapse file

‎…lel/test-heapsnapshot-near-heap-limit.js‎ ‎…mel/test-heapsnapshot-near-heap-limit.js‎test/parallel/test-heapsnapshot-near-heap-limit.js renamed to test/pummel/test-heapsnapshot-near-heap-limit.js test/parallel/test-heapsnapshot-near-heap-limit.js renamed to test/pummel/test-heapsnapshot-near-heap-limit.js

Copy file name to clipboardExpand all lines: test/pummel/test-heapsnapshot-near-heap-limit.js
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
'use strict';
22

33
const common = require('../common');
4+
5+
if ((process.config.variables.arm_version === '6') ||
6+
(process.config.variables.arm_version === '7')) {
7+
common.skip('Too slow for armv6 and armv7 bots');
8+
}
9+
410
const tmpdir = require('../common/tmpdir');
511
const assert = require('assert');
612
const { spawnSync } = require('child_process');
Collapse file

‎…net-bytes-per-incoming-chunk-overhead.js‎ ‎…net-bytes-per-incoming-chunk-overhead.js‎test/sequential/test-net-bytes-per-incoming-chunk-overhead.js renamed to test/pummel/test-net-bytes-per-incoming-chunk-overhead.js test/sequential/test-net-bytes-per-incoming-chunk-overhead.js renamed to test/pummel/test-net-bytes-per-incoming-chunk-overhead.js

Copy file name to clipboardExpand all lines: test/pummel/test-net-bytes-per-incoming-chunk-overhead.js
+8-1Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,15 @@
22
'use strict';
33

44
const common = require('../common');
5-
if (process.config.variables.asan)
5+
6+
if (process.config.variables.asan) {
67
common.skip('ASAN messes with memory measurements');
8+
}
9+
10+
if ((process.config.variables.arm_version === '6') ||
11+
(process.config.variables.arm_version === '7')) {
12+
common.skip('Too slow for armv6 and armv7 bots');
13+
}
714

815
const assert = require('assert');
916
const net = require('net');
Collapse file

‎…llel/test-webcrypto-derivebits-pbkdf2.js‎ ‎…mmel/test-webcrypto-derivebits-pbkdf2.js‎test/parallel/test-webcrypto-derivebits-pbkdf2.js renamed to test/pummel/test-webcrypto-derivebits-pbkdf2.js test/parallel/test-webcrypto-derivebits-pbkdf2.js renamed to test/pummel/test-webcrypto-derivebits-pbkdf2.js

Copy file name to clipboardExpand all lines: test/pummel/test-webcrypto-derivebits-pbkdf2.js
+7-1Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,14 @@
22

33
const common = require('../common');
44

5-
if (!common.hasCrypto)
5+
if (!common.hasCrypto) {
66
common.skip('missing crypto');
7+
}
8+
9+
if ((process.config.variables.arm_version === '6') ||
10+
(process.config.variables.arm_version === '7')) {
11+
common.skip('Too slow for armv6 and armv7 bots');
12+
}
713

814
const assert = require('assert');
915
const { subtle } = require('crypto').webcrypto;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.