Commit 2259e5d
test: avoid test-cluster-master-* flakiness
Removed reliance on worker exit before arbitrary timeout. Instead of failing
the test after 200 or 1000 ms wait indefinitely for child process exit. If
the test hangs the test harness global timeout will kick in and fail the test.
Note that if the orphaned children are not reaped correctly (in the absence
of init, e.g. Docker) the test will hang and the harness will fail it.
PR-URL: #6531
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>1 parent 5f444ed commit 2259e5dCopy full SHA for 2259e5d
File tree
Expand file treeCollapse file tree
2 files changed
+29
-37
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
2 files changed
+29
-37
lines changedOpen diff view settings
Collapse file
test/parallel/test-cluster-master-error.js
Copy file name to clipboardExpand all lines: test/parallel/test-cluster-master-error.js+21-24Lines changed: 21 additions & 24 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
30 | 30 | |
31 | 31 | |
32 | 32 | |
33 | | - |
| 33 | + |
34 | 34 | |
35 | 35 | |
36 | 36 | |
| ||
39 | 39 | |
40 | 40 | |
41 | 41 | |
42 | | - |
| 42 | + |
43 | 43 | |
44 | 44 | |
45 | | - |
| 45 | + |
46 | 46 | |
47 | 47 | |
48 | 48 | |
| ||
68 | 68 | |
69 | 69 | |
70 | 70 | |
71 | | - |
72 | | - |
| 71 | + |
| 72 | + |
73 | 73 | |
74 | 74 | |
75 | 75 | |
| ||
89 | 89 | |
90 | 90 | |
91 | 91 | |
92 | | - |
93 | | - |
| 92 | + |
| 93 | + |
94 | 94 | |
95 | | - |
96 | | - |
97 | | - |
98 | | - |
99 | | - |
100 | | - |
101 | | - |
102 | | - |
103 | | - |
104 | | - |
| 95 | + |
| 96 | + |
105 | 97 | |
106 | 98 | |
107 | 99 | |
108 | 100 | |
109 | 101 | |
110 | 102 | |
111 | | - |
112 | | - |
113 | | - |
114 | | - |
| 103 | + |
| 104 | + |
| 105 | + |
| 106 | + |
| 107 | + |
| 108 | + |
| 109 | + |
| 110 | + |
| 111 | + |
115 | 112 | |
116 | 113 | |
117 | 114 | |
118 | | - |
119 | | - |
| 115 | + |
| 116 | + |
120 | 117 | |
121 | | - |
| 118 | + |
122 | 119 | |
123 | 120 | |
124 | 121 | |
Collapse file
test/parallel/test-cluster-master-kill.js
Copy file name to clipboardExpand all lines: test/parallel/test-cluster-master-kill.js+8-13Lines changed: 8 additions & 13 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
55 | 55 | |
56 | 56 | |
57 | 57 | |
58 | | - |
| 58 | + |
59 | 59 | |
60 | 60 | |
61 | 61 | |
62 | | - |
63 | | - |
64 | | - |
65 | | - |
66 | | - |
67 | | - |
| 62 | + |
68 | 63 | |
69 | | - |
| 64 | + |
| 65 | + |
| 66 | + |
| 67 | + |
| 68 | + |
| 69 | + |
70 | 70 | |
71 | 71 | |
72 | 72 | |
73 | | - |
74 | | - |
75 | | - |
76 | | - |
77 | | - |
78 | 73 | |
79 | 74 | |
80 | 75 | |
|
0 commit comments