Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2250631

Browse filesBrowse files
Benjamin Coetargos
Benjamin Coe
authored and
targos
committed
build: fail on instrumentation errors
nyc was silently failing to instrument new language features, resulting in a failure to instrument console.js. Refs: #20952 PR-URL: #21071 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rebecca Turner <me@re-becca.org> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
1 parent c050279 commit 2250631
Copy full SHA for 2250631

File tree

Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,8 @@ coverage-build: all
175175
"$(CURDIR)/build/jenkins/scripts/coverage/gcovr-patches-3.4.diff"); fi
176176
if [ -d lib_ ]; then $(RM) -r lib; mv lib_ lib; fi
177177
mv lib lib_
178-
$(NODE) ./node_modules/.bin/nyc instrument --extension .js --extension .mjs lib_/ lib/
178+
NODE_DEBUG=nyc $(NODE) ./node_modules/.bin/nyc instrument --extension .js \
179+
--extension .mjs --exit-on-error lib_/ lib/
179180
$(MAKE)
180181

181182
.PHONY: coverage-test

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.