Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2201484

Browse filesBrowse files
joyeecheungBridgeAR
authored andcommitted
build: turn on custom V8 snapshot by default
This patch re-enables custom V8 snapshot integration. Also renames the experimental configure switch from `--with-node-snapshot` to `--without-node-snapshot` to be consistent with`--without-snapshot` which is used for the default V8 snapshot. PR-URL: #28181 Refs: #27365 Refs: #17058 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 9085412 commit 2201484
Copy full SHA for 2201484

File tree

Expand file treeCollapse file tree

1 file changed

+5
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-7
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+5-7Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -421,10 +421,10 @@
421421
dest='with_ltcg',
422422
help='Use Link Time Code Generation. This feature is only available on Windows.')
423423

424-
parser.add_option('--with-node-snapshot',
424+
parser.add_option('--without-node-snapshot',
425425
action='store_true',
426-
dest='with_node_snapshot',
427-
help='Turn on V8 snapshot integration. Currently experimental.')
426+
dest='without_node_snapshot',
427+
help='Turn off V8 snapshot integration. Currently experimental.')
428428

429429
intl_optgroup.add_option('--download',
430430
action='store',
@@ -942,11 +942,9 @@ def configure_node(o):
942942
o['variables']['want_separate_host_toolset'] = int(
943943
cross_compiling and want_snapshots)
944944

945-
if options.with_node_snapshot:
946-
o['variables']['node_use_node_snapshot'] = 'true'
945+
if not options.without_node_snapshot:
946+
o['variables']['node_use_node_snapshot'] = b(not cross_compiling)
947947
else:
948-
# Default to false for now.
949-
# TODO(joyeecheung): enable it once we fix the hashseed uniqueness
950948
o['variables']['node_use_node_snapshot'] = 'false'
951949

952950
if target_arch == 'arm':

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.