Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 21a43bd

Browse filesBrowse files
lpincatargos
authored andcommitted
stream: simplify uint8ArrayToBuffer helper
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041 Fixes: #30040 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent ae39039 commit 21a43bd
Copy full SHA for 21a43bd

File tree

Expand file treeCollapse file tree

1 file changed

+6
-17
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-17
lines changed
Open diff view settings
Collapse file

‎lib/stream.js‎

Copy file name to clipboardExpand all lines: lib/stream.js
+6-17Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121

2222
'use strict';
2323

24-
const { Buffer } = require('buffer');
2524
const pipeline = require('internal/streams/pipeline');
2625
const eos = require('internal/streams/end-of-stream');
26+
const internalBuffer = require('internal/buffer');
2727

2828
// Note: export Stream before Readable/Writable/Duplex/...
2929
// to avoid a cross-reference(require) issues
@@ -42,19 +42,8 @@ Stream.finished = eos;
4242
Stream.Stream = Stream;
4343

4444
Stream._isUint8Array = require('internal/util/types').isUint8Array;
45-
46-
try {
47-
const internalBuffer = require('internal/buffer');
48-
Stream._uint8ArrayToBuffer = function _uint8ArrayToBuffer(chunk) {
49-
return new internalBuffer.FastBuffer(chunk.buffer,
50-
chunk.byteOffset,
51-
chunk.byteLength);
52-
};
53-
} catch (e) { // eslint-disable-line no-unused-vars
54-
}
55-
56-
if (!Stream._uint8ArrayToBuffer) {
57-
Stream._uint8ArrayToBuffer = function _uint8ArrayToBuffer(chunk) {
58-
return Buffer.prototype.slice.call(chunk);
59-
};
60-
}
45+
Stream._uint8ArrayToBuffer = function _uint8ArrayToBuffer(chunk) {
46+
return new internalBuffer.FastBuffer(chunk.buffer,
47+
chunk.byteOffset,
48+
chunk.byteLength);
49+
};

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.