Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2089814

Browse filesBrowse files
mhdawsonMylesBorins
mhdawson
authored and
MylesBorins
committed
test: properly tag anonymous namespaces
For tests that use anonymous namespaces, some tagged the close of the namespace with 'namespace' while others used 'anonymous namespace'. It was suggested I should use 'anonymous namespace' in a recent PR review so make all of the tests consistent with this. PR-URL: #18583 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent a667ac1 commit 2089814
Copy full SHA for 2089814

File tree

Expand file treeCollapse file tree

8 files changed

+8
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

8 files changed

+8
-8
lines changed
Open diff view settings
Collapse file

‎test/addons-napi/test_make_callback/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons-napi/test_make_callback/binding.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,6 @@ napi_value Init(napi_env env, napi_value exports) {
5454
return exports;
5555
}
5656

57-
} // namespace
57+
} // anonymous namespace
5858

5959
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
Collapse file

‎test/addons-napi/test_make_callback_recurse/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons-napi/test_make_callback_recurse/binding.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@ napi_value Init(napi_env env, napi_value exports) {
2828
return exports;
2929
}
3030

31-
} // namespace
31+
} // anonymous namespace
3232

3333
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
Collapse file

‎test/addons/async-hooks-id/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons/async-hooks-id/binding.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ void Initialize(Local<Object> exports) {
2222
NODE_SET_METHOD(exports, "getTriggerAsyncId", GetTriggerAsyncId);
2323
}
2424

25-
} // namespace
25+
} // anonymous namespace
2626

2727
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
Collapse file

‎test/addons/async-resource/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons/async-resource/binding.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,6 @@ void Initialize(Local<Object> exports) {
109109
NODE_SET_METHOD(exports, "getResource", GetResource);
110110
}
111111

112-
} // namespace
112+
} // anonymous namespace
113113

114114
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
Collapse file

‎test/addons/callback-scope/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons/callback-scope/binding.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,6 @@ void Initialize(v8::Local<v8::Object> exports) {
6969
NODE_SET_METHOD(exports, "testResolveAsync", TestResolveAsync);
7070
}
7171

72-
} // namespace
72+
} // anonymous namespace
7373

7474
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
Collapse file

‎test/addons/make-callback-recurse/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons/make-callback-recurse/binding.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ void Initialize(Local<Object> exports) {
2626
NODE_SET_METHOD(exports, "makeCallback", MakeCallback);
2727
}
2828

29-
} // namespace
29+
} // anonymous namespace
3030

3131
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
Collapse file

‎test/addons/make-callback/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons/make-callback/binding.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ void Initialize(v8::Local<v8::Object> exports) {
3434
NODE_SET_METHOD(exports, "makeCallback", MakeCallback);
3535
}
3636

37-
} // namespace
37+
} // anonymous namespace
3838

3939
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
Collapse file

‎test/cctest/test_inspector_socket_server.cc‎

Copy file name to clipboardExpand all lines: test/cctest/test_inspector_socket_server.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ static const std::string WsHandshakeRequest(const std::string& target_id) {
398398
"Sec-WebSocket-Key: aaa==\r\n"
399399
"Sec-WebSocket-Version: 13\r\n\r\n";
400400
}
401-
} // namespace
401+
} // anonymous namespace
402402

403403

404404
TEST_F(InspectorSocketServerTest, InspectorSessions) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.