Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2069c4e

Browse filesBrowse files
bnoordhuisMylesBorins
bnoordhuis
authored and
MylesBorins
committed
build: disable libstdc++ debug containers globally
Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: #30056 PR-URL: #30147 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 435341a commit 2069c4e
Copy full SHA for 2069c4e

File tree

Expand file treeCollapse file tree

2 files changed

+0
-12
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+0
-12
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@
3030
'openssl_fips%': '',
3131
'openssl_no_asm%': 0,
3232

33-
# Some STL containers (e.g. std::vector) do not preserve ABI compatibility
34-
# between debug and non-debug mode.
35-
'disable_glibcxx_debug': 1,
36-
3733
# Don't use ICU data file (icudtl.dat) from V8, we use our own.
3834
'icu_use_data_file_flag%': 0,
3935

Collapse file

‎tools/v8_gypfiles/toolchain.gypi‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/toolchain.gypi
-8Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@
6464
# Print to stdout on Android.
6565
'v8_android_log_stdout%': 0,
6666

67-
# Force disable libstdc++ debug mode.
68-
'disable_glibcxx_debug%': 0,
69-
7067
'v8_enable_backtrace%': 0,
7168

7269
# Enable profiling support. Only required on Windows.
@@ -1167,11 +1164,6 @@
11671164
# Support for backtrace_symbols.
11681165
'ldflags': [ '-rdynamic' ],
11691166
}],
1170-
['OS=="linux" and disable_glibcxx_debug==0', {
1171-
# Enable libstdc++ debugging facilities to help catch problems
1172-
# early, see http://crbug.com/65151 .
1173-
'defines': ['_GLIBCXX_DEBUG=1',],
1174-
}],
11751167
['OS=="aix"', {
11761168
'ldflags': [ '-Wl,-bbigtoc' ],
11771169
'conditions': [

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.