Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 20430ae

Browse filesBrowse files
Vasili SkurydzinMylesBorins
Vasili Skurydzin
authored and
MylesBorins
committed
deps: V8: Add virtual dtor to avoid aix gcc error
deps/v8/src/torque/file-visitor.h: * Not currently present in v8/master deps/v8/third_party/antlr4/BUILD.gn: * Use current_os variable to avoid is_aix being undefined. The following patch to v8/build solves this issue for v8/master: * a1a12ef3b343f9e75c630ed6dc8f1ea44a8a747b However, the version of '/chromium/src/build.git' cannot be updated to include this patch in v8/DEPS file. (could potentially cause issues for other platforms) The change to deps/v8/src/torque/file-visitor.h is a workaround for origin/v10.x-staging branch. PR-URL: #23695 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
1 parent d3fb599 commit 20430ae
Copy full SHA for 20430ae

File tree

Expand file treeCollapse file tree

3 files changed

+6
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+6
-2
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
# Reset this number to 0 on major V8 upgrades.
3535
# Increment by one for each non-official patch applied to deps/v8.
36-
'v8_embedder_string': '-node.43',
36+
'v8_embedder_string': '-node.44',
3737

3838
# Enable disassembler for `--print-code` v8 options
3939
'v8_enable_disassembler': 1,
Collapse file

‎deps/v8/src/torque/file-visitor.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/torque/file-visitor.h
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ namespace torque {
2121

2222
class FileVisitor {
2323
public:
24+
#if defined(__GNUC__) && V8_OS_AIX
25+
// prevent non-virtual-dtor gcc error on Aix
26+
virtual ~FileVisitor() = default;
27+
#endif
2428
explicit FileVisitor(GlobalContext& global_context)
2529
: global_context_(global_context),
2630
declarations_(global_context.declarations()),
Collapse file

‎deps/v8/third_party/antlr4/BUILD.gn‎

Copy file name to clipboardExpand all lines: deps/v8/third_party/antlr4/BUILD.gn
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ config("antlr-compatibility") {
99
"-Wno-unused-but-set-variable",
1010
]
1111
}
12-
if (is_aix) {
12+
if (current_os == "aix") {
1313
cflags += [ "-fdollars-in-identifiers" ]
1414
}
1515
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.