Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1fc30a8

Browse filesBrowse files
mcollinadanielleadams
authored andcommitted
stream,zlib: do not use _stream_* anymore
PR-URL: #36618 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 72b0ab0 commit 1fc30a8
Copy full SHA for 1fc30a8

File tree

Expand file treeCollapse file tree

3 files changed

+16
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+16
-3
lines changed
Open diff view settings
Collapse file

‎lib/internal/streams/pipeline.js‎

Copy file name to clipboardExpand all lines: lib/internal/streams/pipeline.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ function pipeline(...streams) {
215215
}
216216
} else {
217217
if (!PassThrough) {
218-
PassThrough = require('_stream_passthrough');
218+
PassThrough = require('internal/streams/passthrough');
219219
}
220220

221221
// If the last argument to pipeline is not a stream
Collapse file

‎lib/zlib.js‎

Copy file name to clipboardExpand all lines: lib/zlib.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ const {
5252
},
5353
hideStackFrames
5454
} = require('internal/errors');
55-
const Transform = require('_stream_transform');
55+
const { Transform, finished } = require('stream');
5656
const {
5757
deprecate
5858
} = require('internal/util');
@@ -62,7 +62,6 @@ const {
6262
} = require('internal/util/types');
6363
const binding = internalBinding('zlib');
6464
const assert = require('internal/assert');
65-
const finished = require('internal/streams/end-of-stream');
6665
const {
6766
Buffer,
6867
kMaxLength
Collapse file
+14Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
/* eslint-disable node-core/required-modules */
2+
/* eslint-disable node-core/require-common-first */
3+
4+
'use strict';
5+
6+
// We are not loading common because it will load the stream module,
7+
// defeating the purpose of this test.
8+
9+
const { gzipSync } = require('zlib');
10+
11+
// Avoid regressions such as https://github.com/nodejs/node/issues/36615
12+
13+
// This must not throw
14+
gzipSync('fooobar');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.